TrueCloudLab/frostfs-contract
23
0
Fork 19
Code Issues 15 Pull requests Projects Releases 2 Activity Actions

frostfsid: Fix remove subject #141

Merged
fyrchik merged 1 commit from achuprov/frostfs-contract:bugfix/frostfsid_remove_sbj into master 2024-12-12 11:46:11 +00:00
Conversation 0 Commits 1 Files changed 2 +8
achuprov commented 2024-12-12 10:28:29 +00:00
Member
Copy link

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-12-12 10:28:29 +00:00
[#141] frostfsid: Fix remove subject
All checks were successful
DCO action / DCO (pull_request) Successful in 59s
Details
Code generation / Generate wrappers (pull_request) Successful in 2m53s
Details
Tests / Tests (pull_request) Successful in 3m5s
Details
467a1c6d00 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from fyrchik 2024-12-12 10:28:29 +00:00
achuprov requested review from storage-core-developers 2024-12-12 10:28:29 +00:00
achuprov requested review from storage-core-committers 2024-12-12 10:28:29 +00:00
fyrchik approved these changes 2024-12-12 10:33:24 +00:00
Dismissed
fyrchik left a comment
Owner
Copy link

Please, replace fix remove subject with a more descriptive message.

Please, replace `fix remove subject` with a more descriptive message.
achuprov force-pushed bugfix/frostfsid_remove_sbj from 467a1c6d00 to 7d8118cab6 2024-12-12 10:38:07 +00:00 Compare
aarifullin approved these changes 2024-12-12 10:38:15 +00:00
fyrchik requested changes 2024-12-12 10:41:00 +00:00
fyrchik left a comment
Owner
Copy link

There is an unnecessary \ in the commit message
Suggestionfrostfsid: Remove address index in DeleteSubject()

There is an unnecessary `\` in the commit message Suggestion`frostfsid: Remove address index in DeleteSubject()`
achuprov force-pushed bugfix/frostfsid_remove_sbj from 7d8118cab6 to 28a50e323c 2024-12-12 11:39:29 +00:00 Compare
achuprov force-pushed bugfix/frostfsid_remove_sbj from 28a50e323c to 31709a3d95 2024-12-12 11:42:12 +00:00 Compare
fyrchik merged commit 31709a3d95 into master 2024-12-12 11:46:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#141
No description provided.
Delete branch "achuprov/frostfs-contract:bugfix/frostfsid_remove_sbj"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?