TrueCloudLab
/
frostfs-contract
22
0
Fork 17
Code Issues 9 Pull Requests 1 Actions Releases 2 Activity

Add public key as argument for container_contract.Delete() method #28

Merged
fyrchik merged 1 commits from acid-ant/frostfs-contract:feature/27-cnt-del-add-arg into master 2023-06-16 11:54:53 +00:00
Conversation 0 Commits 1 Files Changed 2
acid-ant commented 2023-06-01 08:37:45 +00:00
Collaborator

Close #27

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #27 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2023-06-01 08:37:52 +00:00
acid-ant requested review from storage-core-developers 2023-06-01 08:37:53 +00:00
fyrchik requested review from storage-services-committers 2023-06-01 10:55:22 +00:00
fyrchik requested review from storage-services-developers 2023-06-01 10:55:22 +00:00
fyrchik reviewed 2023-06-01 10:56:50 +00:00
container/container_contract.go Outdated
@ -311,3 +311,3 @@
//
// If the container doesn't exist, it panics with NotFoundError.
func Delete(containerID []byte, signature interop.Signature, token []byte) {
func Delete(containerID []byte, signature interop.Signature, token []byte, publicKey interop.PublicKey) {
fyrchik commented 2023-06-01 10:56:50 +00:00
Owner

What about making it the third parameter (like in Put)?

What about making it the third parameter (like in `Put`)?
acid-ant commented 2023-06-01 11:11:30 +00:00
Poster
Collaborator

Done.

Done.
fyrchik marked this conversation as resolved
acid-ant force-pushed feature/27-cnt-del-add-arg from dc0e6c5e73 to 2da0ff5750 2023-06-01 11:09:18 +00:00 Compare
dstepanov-yadro approved these changes 2023-06-02 07:50:32 +00:00
aarifullin approved these changes 2023-06-05 11:22:00 +00:00
alexvanin requested changes 2023-06-06 08:27:11 +00:00
container/container_contract.go
@ -311,3 +311,3 @@
//
// If the container doesn't exist, it panics with NotFoundError.
func Delete(containerID []byte, signature interop.Signature, token []byte) {
func Delete(containerID []byte, signature interop.Signature, publicKey interop.PublicKey, token []byte) {
alexvanin commented 2023-06-06 08:27:10 +00:00
Owner

It should break compatibility with current version of the node. For the Neo VM Delete() with 3 arguments and Delete() with 4 arguments are completely different methods.

I suggest to add one more method and reuse the code of Delete() method. See Put() and PutNamed() methods. So newer versions of node will use new method and older versions stick with current Delete() method.

It should break compatibility with current version of the node. For the Neo VM `Delete()` with 3 arguments and `Delete()` with 4 arguments are completely different methods. I suggest to add one more method and reuse the code of `Delete()` method. See `Put()` and `PutNamed()` methods. So newer versions of node will use new method and older versions stick with current `Delete()` method.
alexvanin commented 2023-06-06 08:28:26 +00:00
Owner

However, if we don't care about compatibility there for some reason, this is okay.

However, if we don't care about compatibility there for some reason, this is okay.
fyrchik commented 2023-06-14 11:13:57 +00:00
Owner

We can mark it as deprecated and use https://github.com/nspcc-dev/neo-go/blob/master/docs/compiler.md#Overloads .

We can mark it as deprecated and use https://github.com/nspcc-dev/neo-go/blob/master/docs/compiler.md#Overloads .
👍 2
fyrchik commented 2023-06-14 11:13:57 +00:00
Owner

We can mark it as deprecated and use https://github.com/nspcc-dev/neo-go/blob/master/docs/compiler.md#Overloads .

We can mark it as deprecated and use https://github.com/nspcc-dev/neo-go/blob/master/docs/compiler.md#Overloads .
alexvanin commented 2023-06-15 10:22:27 +00:00
Owner

Let's break compatibility because we don't have any public networks to be compatible with.

Let's break compatibility because we don't have any public networks to be compatible with.
alexvanin approved these changes 2023-06-15 10:22:32 +00:00
fyrchik merged commit 2da0ff5750 into master 2023-06-16 11:54:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
aarifullin
alexvanin
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#28
There is no content yet.
Delete Branch "acid-ant/frostfs-contract:feature/27-cnt-del-add-arg"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?