ir: Use public key when validate container deletion #415

acid-ant · 2023-06-01T09:00:54Z

acid-ant commented

2023-06-01 09:00:54 +00:00

Close #303

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Blocked by TrueCloudLab/frostfs-contract#28

Close #303 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com> Blocked by https://git.frostfs.info/TrueCloudLab/frostfs-contract/pulls/28

acid-ant requested review from storage-core-committers 2023-06-01 09:01:07 +00:00

acid-ant requested review from storage-core-developers 2023-06-01 09:01:07 +00:00

aarifullin reviewed 2023-06-01 10:43:26 +00:00

pkg/morph/event/container/delete_notary.go Outdated

					
				@ -18,2 +18,4 @@

				}

				func (d *Delete) setPublicKey(v []byte) {

					if v != nil {

aarifullin commented

2023-06-01 10:43:26 +00:00

Don't you find the v != nil unnecessary?

Don't you find the `v != nil` unnecessary?

👍 1

aarifullin approved these changes 2023-06-01 10:43:43 +00:00

acid-ant force-pushed bugfix/303-del-cnt-by-owner from 32a047ae1d to 02f4d0fc9f

2023-06-01 10:49:14 +00:00

Compare

acid-ant force-pushed bugfix/303-del-cnt-by-owner from 02f4d0fc9f to 886b55fb77

2023-06-01 11:20:53 +00:00

Compare

fyrchik added the

blocked

label 2023-06-01 13:23:54 +00:00

acid-ant force-pushed bugfix/303-del-cnt-by-owner from 886b55fb77 to 47792cf183

2023-06-16 12:52:05 +00:00

Compare

acid-ant requested review from storage-core-developers 2023-06-16 12:52:20 +00:00

aarifullin approved these changes 2023-06-19 09:56:21 +00:00

fyrchik approved these changes 2023-06-20 08:02:40 +00:00

fyrchik merged commit 50caa388b0 into master

2023-06-20 08:02:49 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#415