Implement address parsing from TXT record #96

New issue

Open

opened 2024-06-18 07:03:39 +00:00 by fyrchik · 1 comment

fyrchik commented

2024-06-18 07:03:39 +00:00

Owner

We have multiple places where we parse NNS records:

TrueCloudLab/frostfs-sdk-go – ns/nns.go
Line 151 in TrueCloudLab/frostfs-sdk-go@1a5886e
recordValue, err := arr[i].TryBytes()
https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/nns.go#L161
https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/cmd/frostfs-adm/internal/modules/morph/helper/initialize.go#L123

It would be beneficial to have this wrapper in a single place (as well as the opposite converter).
We add this to the rpcclient/ package, together with the autogenerated code, but in a different file.

func ParseHash(string) (util.Uint160, error)
func ResolveHash(ContractReader) (util.Uint160, error)

Also, see #91.

We have multiple places where we parse NNS records: - https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/1a5886e776de79fc6598838242e4dc7ff21e7bea/ns/nns.go#L151 - https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/nns.go#L161 - https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/cmd/frostfs-adm/internal/modules/morph/helper/initialize.go#L123 It would be beneficial to have this wrapper in a single place (as well as the opposite converter). We add this to the `rpcclient/` package, together with the autogenerated code, but in a different file. ``` func ParseHash(string) (util.Uint160, error) func ResolveHash(ContractReader) (util.Uint160, error) ``` Also, see https://git.frostfs.info/TrueCloudLab/frostfs-contract/issues/91.

fyrchik commented

2024-08-05 12:48:15 +00:00

Author

Owner

Also, see #93