Move struct parsers should to `rpcclient/` packages #93

New issue

Open

opened 2024-05-07 10:04:28 +00:00 by fyrchik · 0 comments

fyrchik commented

2024-05-07 10:04:28 +00:00

Owner

Consider https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/branch/master/frostfsid/client/client.go#L249. parseSubjectExtended is used privately and should be duplicated in the client code (see TrueCloudLab/frostfs-node#1117).

A better approach would be to have sth like ParseSubjectExtended([]stackitem.Item) or UnwrapSubjectExtended(*result.Invoke, error) together with the autogenerated code.
In the bright future, it will surely support generating custom structs.

Consider https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/branch/master/frostfsid/client/client.go#L249. `parseSubjectExtended` is used privately and should be duplicated in the client code (see https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1117). A better approach would be to have sth like `ParseSubjectExtended([]stackitem.Item)` or `UnwrapSubjectExtended(*result.Invoke, error)` together with the autogenerated code. In the bright future, it will surely support generating custom structs.