TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 106 Pull requests 12 Projects Releases 2 Activity Actions

Set group id to APE requests for tree, container and object services #1117

Merged
fyrchik merged 4 commits from aarifullin/frostfs-node:feat/ape_fill_group_id into master 2024-05-07 10:01:24 +00:00
Conversation 1 Commits 4 Files changed 17 +529 -77
aarifullin commented 2024-05-02 18:20:08 +00:00
Member
Copy link
  • morph: Make frostfsid client provide GetSubjectExtended method.
  • Make tree, object and container services use SubjectProvider interface.
  • Introduce FormFrostfsIDRequestProperties method. FormFrostfsIDRequestProperties gets user claim tags and group id and sets them as ape request properties.
  • Make tree, container and object service use the method.
  • Fix unit-tests.
* morph: Make frostfsid client provide GetSubjectExtended method. * Make tree, object and container services use SubjectProvider interface. * Introduce `FormFrostfsIDRequestProperties` method. `FormFrostfsIDRequestProperties` gets user claim tags and group id and sets them as ape request properties. * Make tree, container and object service use the method. * Fix unit-tests.
aarifullin force-pushed feat/ape_fill_group_id from 2a8b048934 to a9a23a5741 2024-05-02 18:21:15 +00:00 Compare
requested reviews from storage-core-committers, storage-core-developers 2024-05-02 18:28:05 +00:00
requested review from dkirillov 2024-05-02 18:29:17 +00:00
aarifullin force-pushed feat/ape_fill_group_id from a9a23a5741 to 4da4327aea 2024-05-02 18:30:42 +00:00 Compare
dkirillov approved these changes 2024-05-03 06:12:06 +00:00
aarifullin changed title from Set group id to APE requests for tree, container and object services to WIP: Set group id to APE requests for tree, container and object services 2024-05-03 09:30:33 +00:00
aarifullin commented 2024-05-03 09:31:46 +00:00
Author
Member
Copy link

Rework is required: frostfsid cache should be introduced

Rework is required: frostfsid cache should be introduced
aarifullin changed title from WIP: Set group id to APE requests for tree, container and object services to Set group id to APE requests for tree, container and object services 2024-05-06 16:31:04 +00:00
requested review from dkirillov 2024-05-06 16:31:07 +00:00
dkirillov reviewed 2024-05-07 06:50:31 +00:00
cmd/frostfs-node/frostfsid.go Outdated
@ -0,0 +28,4 @@
}
func (m *morphFrostfsIDCache) GetSubject(addr util.Uint160) (*client.Subject, error) {
result, found := m.subjCache.Get(addr)
dkirillov commented 2024-05-07 06:50:30 +00:00
Member
Copy link

Should we also check m.subjExtCache here? Or update m.subjCache in GetSubjectExtended as well

Should we also check `m.subjExtCache` here? Or update `m.subjCache` in `GetSubjectExtended` as well
aarifullin commented 2024-05-07 08:02:12 +00:00
Author
Member
Copy link

Or update m.subjCache in GetSubjectExtended as well

I think you're right

> Or update m.subjCache in GetSubjectExtended as well I think you're right
aarifullin commented 2024-05-07 08:20:38 +00:00
Author
Member
Copy link

For now subjCache is also refreshed

For now `subjCache` is also refreshed
dkirillov approved these changes 2024-05-07 06:51:22 +00:00
fyrchik approved these changes 2024-05-07 07:05:06 +00:00
pkg/ape/request/frostfsid.go Outdated
@ -0,0 +22,4 @@
return reqProps, nil
}
for k, v := range subj.KV {
properyKey := fmt.Sprintf(commonschema.PropertyKeyFormatFrostFSIDUserClaim, k)
fyrchik commented 2024-05-07 07:02:50 +00:00
Owner
Copy link

typo in propertyKey

typo in `propertyKey`
aarifullin commented 2024-05-07 08:19:30 +00:00
Author
Member
Copy link

Fixed!

Fixed!
pkg/morph/client/frostfsid/subject.go
@ -119,0 +214,4 @@
return res, nil
}
func parseGroup(structArr []stackitem.Item) (*frostfsidclient.Group, error) {
fyrchik commented 2024-05-07 07:04:31 +00:00
Owner
Copy link

@dkirillov do we have similar code in s3-gw?

@dkirillov do we have similar code in s3-gw?
dkirillov commented 2024-05-07 09:14:48 +00:00
Member
Copy link

No. We use client from frostfs-contract repo that parses it for us

Line 253 in TrueCloudLab/frostfs-contract@db36131
func (c Client) GetSubjectExtended(addr util.Uint160) (*SubjectExtended, error) {

No. We use client from frostfs-contract repo that parses it for us https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/db361318009cc9c9df97133c8c2acedad4eb2fd4/frostfsid/client/client.go#L253
aarifullin force-pushed feat/ape_fill_group_id from ea225d4346 to c11c936112 2024-05-07 08:19:23 +00:00 Compare
fyrchik approved these changes 2024-05-07 08:51:18 +00:00
requested reviews from dkirillov, fyrchik 2024-05-07 09:02:32 +00:00
dkirillov approved these changes 2024-05-07 09:16:12 +00:00
fyrchik merged commit 9cc51f86b7 into master 2024-05-07 10:01:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dkirillov
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1117
No description provided.
Delete branch "aarifullin/frostfs-node:feat/ape_fill_group_id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?