TrueCloudLab/frostfs-contract
22
0
Fork 19
Code Issues 12 Pull requests 1 Projects Releases 2 Activity Actions

[#107] Add client method ListFullSubjects #107

Merged
fyrchik merged 1 commit from d.zverev/frostfs-contract:feature/frostfsid-add-list-subjects into master 2024-08-28 09:18:25 +00:00
Conversation 1 Commits 1 Files changed 1 +38
d.zverev commented 2024-08-27 09:51:55 +00:00
Contributor
Copy link

Add ListFullSubjects to frostfsid client. Method slice of Subjects for the given slice of hashes.

Signed-off-by: d.zverev d.zverev@yadro.com

Add ListFullSubjects to frostfsid client. Method slice of Subjects for the given slice of hashes. Signed-off-by: d.zverev <d.zverev@yadro.com>
d.zverev added 1 commit 2024-08-27 09:51:57 +00:00
[] Add client method ListFullSubjects
Some checks reported warnings
DCO action / DCO (pull_request) Has been cancelled
Details
Tests / Tests (1.21) (pull_request) Has been cancelled
Details
Tests / Tests (1.22) (pull_request) Has been cancelled
Details
82b6da56aa 
Signed-off-by: d.zverev <d.zverev@yadro.com>
d.zverev force-pushed feature/frostfsid-add-list-subjects from 82b6da56aa to 0ee5ddc02d 2024-08-27 09:52:41 +00:00 Compare
d.zverev changed title from [] Add client method ListFullSubjects to [#107] Add client method ListFullSubjects 2024-08-27 09:53:03 +00:00
d.zverev requested review from storage-core-developers 2024-08-27 10:03:55 +00:00
d.zverev requested review from storage-core-committers 2024-08-27 10:03:56 +00:00
d.zverev force-pushed feature/frostfsid-add-list-subjects from 0ee5ddc02d to b7dfa43884 2024-08-27 10:05:09 +00:00 Compare
acid-ant reviewed 2024-08-27 10:38:44 +00:00
frostfsid/client/client.go Outdated
@ -260,6 +265,35 @@ func (c Client) ListSubjects() ([]util.Uint160, error) {
return UnwrapArrayOfUint160(commonclient.ReadIteratorItems(c.act, iteratorBatchSize, c.contract, listSubjectsMethod))
}
// ListSubjects gets list of subjects.
acid-ant commented 2024-08-27 10:38:44 +00:00
Member
Copy link

Please update comment accordingly to method.

Please update comment accordingly to method.
d.zverev commented 2024-08-27 10:43:41 +00:00
Author
Contributor
Copy link

Fixed.

Fixed.
d.zverev force-pushed feature/frostfsid-add-list-subjects from b7dfa43884 to fa66432137 2024-08-27 10:42:33 +00:00 Compare
fyrchik requested review from dkirillov 2024-08-27 10:54:25 +00:00
fyrchik requested review from storage-services-committers 2024-08-27 10:54:26 +00:00
fyrchik requested review from storage-services-developers 2024-08-27 10:54:26 +00:00
fyrchik requested changes 2024-08-27 10:55:09 +00:00
frostfsid/client/client.go Outdated
@ -263,0 +280,4 @@
if invoker.State != vmstate.Halt.String() {
return nil, fmt.Errorf("invocation failed: %s", invoker.FaultException)
}
subjects := make([]*Subject, 0)
fyrchik commented 2024-08-27 10:55:07 +00:00
Owner
Copy link

please, just var subjects []*Subject or preallocate with make([]*Subject, 0, len(invoker.Stack))

please, just `var subjects []*Subject` or preallocate with `make([]*Subject, 0, len(invoker.Stack))`
d.zverev commented 2024-08-27 10:59:29 +00:00
Author
Contributor
Copy link

Changed to var subjects []*Subject

Changed to `var subjects []*Subject`
fyrchik marked this conversation as resolved
d.zverev force-pushed feature/frostfsid-add-list-subjects from fa66432137 to d6f1c8dfa4 2024-08-27 10:59:14 +00:00 Compare
fyrchik commented 2024-08-27 11:49:23 +00:00
Owner
Copy link

@dkirillov waiting for your approval

@dkirillov waiting for your approval
fyrchik approved these changes 2024-08-27 11:49:38 +00:00
dkirillov reviewed 2024-08-27 11:53:35 +00:00
frostfsid/client/client.go Outdated
@ -263,0 +280,4 @@
if invoker.State != vmstate.Halt.String() {
return nil, fmt.Errorf("invocation failed: %s", invoker.FaultException)
}
var subjects []*Subject
dkirillov commented 2024-08-27 11:53:35 +00:00
Member
Copy link

Should we pre-allocatate memory for slice? It seems we know exact size

Should we pre-allocatate memory for slice? It seems we know exact size
dkirillov commented 2024-08-27 11:53:35 +00:00
Member
Copy link

Should we pre-allocatate memory for slice? It seems we know exact size

Should we pre-allocatate memory for slice? It seems we know exact size
d.zverev commented 2024-08-27 11:58:43 +00:00
Author
Contributor
Copy link

We can, but according previous comment i choose another option.
I can change it to pre-allocated memory if you prefer this type of definition.

We can, but according previous [comment](https://git.frostfs.info/TrueCloudLab/frostfs-contract/pulls/107#issuecomment-49158) i choose another option. I can change it to pre-allocated memory if you prefer this type of definition.
d.zverev commented 2024-08-27 12:13:05 +00:00
Author
Contributor
Copy link

Fixed.

Fixed.
dkirillov marked this conversation as resolved
dkirillov approved these changes 2024-08-27 11:53:45 +00:00
d.zverev force-pushed feature/frostfsid-add-list-subjects from d6f1c8dfa4 to 3fd0e27df4 2024-08-27 12:12:58 +00:00 Compare
dkirillov approved these changes 2024-08-27 12:21:11 +00:00
acid-ant reviewed 2024-08-27 12:22:07 +00:00
frostfsid/client/client.go Outdated
@ -263,0 +283,4 @@
subjects := make([]*Subject, 0, len(invoker.Stack))
for _, item := range invoker.Stack {
val := item.Value().([]stackitem.Item)
acid-ant commented 2024-08-27 12:22:07 +00:00
Member
Copy link

Do we need val here?

Do we need `val` here?
d.zverev commented 2024-08-27 12:28:10 +00:00
Author
Contributor
Copy link

Yes, i miss type conversion check.
Add check.

Yes, i miss type conversion check. Add check.
d.zverev force-pushed feature/frostfsid-add-list-subjects from 3fd0e27df4 to a6eb53ee59 2024-08-27 12:27:12 +00:00 Compare
d.zverev force-pushed feature/frostfsid-add-list-subjects from a6eb53ee59 to 17d3e02136 2024-08-27 12:31:55 +00:00 Compare
acid-ant approved these changes 2024-08-27 12:45:02 +00:00
d.zverev force-pushed feature/frostfsid-add-list-subjects from 17d3e02136 to c142971bfd 2024-08-27 13:18:01 +00:00 Compare
d.zverev requested review from dkirillov 2024-08-27 14:10:48 +00:00
d.zverev requested review from fyrchik 2024-08-27 14:10:52 +00:00
dkirillov approved these changes 2024-08-28 06:16:32 +00:00
fyrchik merged commit c142971bfd into master 2024-08-28 09:18:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#107
No description provided.
Delete branch "d.zverev/frostfs-contract:feature/frostfsid-add-list-subjects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?