TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 18 Pull requests Projects Releases 3 Activity Actions

nns: Add notification sending #109

Merged
fyrchik merged 1 commit from achuprov/frostfs-contract:feat/add_nnsNotification into master 2024-09-09 06:24:55 +00:00
Conversation 0 Commits 1 Files changed 4 +414 -4
achuprov commented 2024-09-05 15:14:24 +00:00
Member
Copy link

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-09-05 15:14:24 +00:00
[#109] nns: Add notification sending
Some checks failed
DCO action / DCO (pull_request) Successful in 41s
Details
Tests / Tests (pull_request) Failing after 1m0s
Details
96c019ffd8 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov force-pushed feat/add_nnsNotification from 96c019ffd8 to fbb5b41f26 2024-09-05 15:17:29 +00:00 Compare
achuprov requested review from storage-core-committers 2024-09-06 09:00:28 +00:00
achuprov requested review from storage-core-developers 2024-09-06 09:00:29 +00:00
dstepanov-yadro approved these changes 2024-09-06 10:32:37 +00:00
Dismissed
fyrchik requested changes 2024-09-06 12:29:57 +00:00
Dismissed
nns/nns_contract.go Outdated
@ -339,1 +339,3 @@
return register(ctx, name, owner, email, refresh, retry, expire, ttl)
st := register(ctx, name, owner, email, refresh, retry, expire, ttl)
if st == true {
runtime.Notify("RegisterDomain", name)
fyrchik commented 2024-09-06 12:27:53 +00:00
Owner
Copy link

If contract provides notification, they should happen on every register, not just the one invoked by user (inside register())

If contract provides notification, they should happen on every register, not just the one invoked by user (inside `register()`)
achuprov commented 2024-09-06 12:44:23 +00:00
Author
Member
Copy link

This can disrupt the order of sending already existing notifications

This can disrupt the order of sending already existing notifications
achuprov commented 2024-09-06 13:38:52 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
achuprov force-pushed feat/add_nnsNotification from fbb5b41f26 to 46407fbd3e 2024-09-06 13:37:43 +00:00 Compare
achuprov dismissed dstepanov-yadro's review 2024-09-06 13:37:43 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant reviewed 2024-09-09 06:14:16 +00:00
rpcclient/nns/client.go
@ -359,0 +432,4 @@
err error
)
index++
e.Name, err = func(item stackitem.Item) (string, error) {
acid-ant commented 2024-09-09 06:14:16 +00:00
Member
Copy link

Why we need func here?

Why we need `func` here?
fyrchik commented 2024-09-09 06:15:33 +00:00
Owner
Copy link

It is automatically generated code, makes it easier to generate

It is automatically generated code, makes it easier to generate
acid-ant commented 2024-09-09 06:20:51 +00:00
Member
Copy link

Oops.

Oops.
acid-ant marked this conversation as resolved
fyrchik approved these changes 2024-09-09 06:16:16 +00:00
acid-ant reviewed 2024-09-09 06:20:04 +00:00
acid-ant approved these changes 2024-09-09 06:22:30 +00:00
fyrchik merged commit 82641e2e99 into master 2024-09-09 06:24:55 +00:00
fyrchik referenced this pull request from a commit 2024-09-09 06:24:57 +00:00
[#109] nns: Add notification sending
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#109
No description provided.
Delete branch "achuprov/frostfs-contract:feat/add_nnsNotification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?