TrueCloudLab/frostfs-contract
22
0
Fork 19
Code Issues 12 Pull requests 1 Projects Releases 2 Activity Actions

nns: Remove unused config #110

Merged
fyrchik merged 1 commit from achuprov/frostfs-contract:fix/nns_unused_nns_config into master 2024-09-06 12:26:21 +00:00
Conversation 0 Commits 1 Files changed 1 -32
achuprov commented 2024-09-06 09:17:24 +00:00
Member
Copy link

We use config.yml to generate wrappers in

Lines 30 to 32 in c142971
define sc_template
$(2)$(1)/$(1)_contract.nef: $(2)$(1)/$(1)_contract.go $(2)$(1)/config.yml
$(NEOGO) contract compile -i $(2)$(1) -c $(if $(2),$(2),$(1)/)config.yml -m $(2)$(1)/config.json -o $(2)$(1)/$(1)_contract.nef

and do not use nns.yml at all
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

We use `config.yml` to generate wrappers in https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/c142971bfdbfd91c4afb0c1dc2bfa978c335ea40/Makefile#L30-L32 and do not use `nns.yml` at all Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-09-06 09:17:25 +00:00
[#110] nns: Remove unused config
All checks were successful
DCO action / DCO (pull_request) Successful in 41s
Details
Tests / Tests (pull_request) Successful in 1m6s
Details
6e244fac04 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2024-09-06 09:20:22 +00:00
achuprov requested review from storage-core-developers 2024-09-06 09:20:22 +00:00
dstepanov-yadro approved these changes 2024-09-06 10:30:12 +00:00
fyrchik approved these changes 2024-09-06 12:26:17 +00:00
fyrchik merged commit 6e244fac04 into master 2024-09-06 12:26:21 +00:00
fyrchik referenced this pull request from a commit 2024-09-06 12:26:22 +00:00
[#110] nns: Remove unused config
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#110
No description provided.
Delete branch "achuprov/frostfs-contract:fix/nns_unused_nns_config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?