TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 16 Pull requests Projects Releases 2 Activity Actions

Make nns/gudz close to RFC #114

Merged
dstepanov-yadro merged 3 commits from achuprov/frostfs-contract:fix/change_gudz into master 2024-11-02 14:21:47 +00:00
Conversation 0 Commits 3 Files changed 8 +604 -6
achuprov commented 2024-09-17 19:45:24 +00:00
Member
Copy link

In this PR:

  • Add 'DeleteRecord'.
  • Fix Delete Domain allow deletion of a domain that has subdomains and add admin rights check.
  • Add docs.
In this PR: - Add 'DeleteRecord'. - Fix `Delete Domain` allow deletion of a domain that has subdomains and add admin rights check. - Add docs.
achuprov added 3 commits 2024-09-17 19:45:24 +00:00 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
[#114] nns: Add docs
All checks were successful
DCO action / DCO (pull_request) Successful in 34s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m6s
Details
Tests / Tests (pull_request) Successful in 1m13s
Details
d9dbe96a64 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov force-pushed fix/change_gudz from d9dbe96a64 to 07af5459f7 2024-09-23 10:30:40 +00:00 Compare
achuprov force-pushed fix/change_gudz from 07af5459f7 to 820bd283c1 2024-09-23 10:36:11 +00:00 Compare
achuprov added 1 commit 2024-09-23 10:36:38 +00:00
[#114] nns: Add docs
All checks were successful
DCO action / DCO (pull_request) Successful in 32s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m6s
Details
Tests / Tests (pull_request) Successful in 1m16s
Details
dc1cb8c297 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov force-pushed fix/change_gudz from dc1cb8c297 to 2b4a5c35b5 2024-09-23 10:58:12 +00:00 Compare
achuprov force-pushed fix/change_gudz from 2b4a5c35b5 to a25f0e493f 2024-09-23 11:14:18 +00:00 Compare
achuprov changed title from WIP: Make nns/gudz close to RFC to Make nns/gudz close to RFC 2024-09-23 11:17:12 +00:00
achuprov requested review from storage-core-committers 2024-09-23 11:17:31 +00:00
achuprov requested review from storage-core-developers 2024-09-23 11:17:40 +00:00
achuprov force-pushed fix/change_gudz from a25f0e493f to 820bd283c1 2024-09-23 12:00:40 +00:00 Compare
achuprov added 1 commit 2024-09-23 12:01:01 +00:00
[#114] nns: Add docs
All checks were successful
DCO action / DCO (pull_request) Successful in 37s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m9s
Details
Tests / Tests (pull_request) Successful in 1m14s
Details
e8ae06bffd 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
dstepanov-yadro approved these changes 2024-09-23 14:28:47 +00:00
Dismissed
aarifullin reviewed 2024-09-24 09:46:20 +00:00
docs/globally-unique-domain-zone.md Outdated
@ -0,0 +63,4 @@
alphabet0.frostfs
sweden
frostfsid.frostfs
bober.animals.org (CNAME: bober.sweden)
aarifullin commented 2024-09-24 09:46:20 +00:00
Member
Copy link

Why bober.animals.org is associated with bober.sweden but not .poland if

frostfs-adm morph nns register --name="bober.poland" --email="email@email.email"
frostfs-adm morph nns  add-record --name="bober.poland" --data="CID" --type="txt"

?

Why `bober.animals.org` is associated with `bober.sweden` but not `.poland` if ``` frostfs-adm morph nns register --name="bober.poland" --email="email@email.email" frostfs-adm morph nns add-record --name="bober.poland" --data="CID" --type="txt" ``` ?
achuprov commented 2024-09-27 09:08:24 +00:00
Author
Member
Copy link

Fixed typo

Fixed typo
aarifullin marked this conversation as resolved
achuprov force-pushed fix/change_gudz from e8ae06bffd to 3e221b973a 2024-09-26 14:09:07 +00:00 Compare
achuprov added 3 commits 2024-09-27 08:55:45 +00:00 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
[#114] nns: Add docs
All checks were successful
DCO action / DCO (pull_request) Successful in 51s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m2s
Details
Tests / Tests (pull_request) Successful in 1m23s
Details
37c772ba1a 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov dismissed dstepanov-yadro's review 2024-09-27 08:55:45 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov requested review from storage-core-committers 2024-09-27 09:08:43 +00:00
aarifullin approved these changes 2024-09-27 10:10:58 +00:00
Dismissed
dstepanov-yadro requested changes 2024-09-27 14:33:49 +00:00
Dismissed
nns/nns_contract.go Outdated
@ -530,0 +544,4 @@
recordsKey := getRecordsKeyByType(tokenId, name, typ)
var previousKey any
keys := storage.Find(ctx, recordsKey, storage.KeysOnly)
dstepanov-yadro commented 2024-09-27 14:18:49 +00:00
Member
Copy link

it := storage.Find please, just like everywhere else

`it := storage.Find` please, just like everywhere else
achuprov marked this conversation as resolved
achuprov force-pushed fix/change_gudz from 37c772ba1a to bce960024f 2024-09-27 14:47:51 +00:00 Compare
achuprov dismissed aarifullin's review 2024-09-27 14:47:51 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro approved these changes 2024-09-27 14:51:12 +00:00
Dismissed
achuprov force-pushed fix/change_gudz from bce960024f to ff2d165c28 2024-09-27 14:51:40 +00:00 Compare
achuprov dismissed dstepanov-yadro's review 2024-09-27 14:51:40 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro approved these changes 2024-09-27 14:54:33 +00:00
a-savchuk approved these changes 2024-09-27 15:01:21 +00:00
dstepanov-yadro merged commit ff2d165c28 into master 2024-09-27 15:02:28 +00:00
dstepanov-yadro referenced this pull request from a commit 2024-09-27 15:02:29 +00:00
[#114] nns: Add docs
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
a-savchuk
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#114
No description provided.
Delete branch "achuprov/frostfs-contract:fix/change_gudz"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?