contract: Add DeletionInfo() method #36

fyrchik · 2023-08-08T06:16:30Z

fyrchik commented

2023-08-08 06:16:30 +00:00

Close #35.

fyrchik added 1 commit 2023-08-08 06:16:31 +00:00

eb299a9063 *: Use multiline lists in yaml config

It is quite hard to navigate in a single-line list of length 10.
Viewing diffs is also more pleasant when a single line has added.
Also, sort everything by alphabet.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2023-08-08 06:16:35 +00:00

fyrchik requested review from storage-core-developers 2023-08-08 06:16:36 +00:00

fyrchik requested review from storage-services-committers 2023-08-08 06:16:42 +00:00

fyrchik requested review from storage-services-developers 2023-08-08 06:16:43 +00:00

dstepanov-yadro approved these changes 2023-08-08 07:12:26 +00:00

acid-ant approved these changes 2023-08-08 07:42:34 +00:00

fyrchik force-pushed check-contract-deletion from a382fc3a51 to eddfb88735

2023-08-08 08:11:52 +00:00

Compare

fyrchik changed title from ~~contract: Add WasDeleted() method~~ to contract: Add DeletionInfo() method

2023-08-08 08:25:00 +00:00

fyrchik requested review from acid-ant 2023-08-08 08:25:07 +00:00

fyrchik requested review from dstepanov-yadro 2023-08-08 08:25:08 +00:00

fyrchik commented

2023-08-08 08:25:42 +00:00

Poster

I have thought about blocks vs epochs, decided to go with epochs, to simplify client code.

aarifullin reviewed 2023-08-10 08:50:14 +00:00

container/container_contract.go Outdated

													
				@ -340,0 +343,4 @@

					Epoch int

				}

				// DeletionInfo method returns true iff a container was deleted previously.

aarifullin commented

2023-08-10 08:50:14 +00:00

iff -> if

`iff` -> `if`

dkirillov commented

2023-08-10 13:23:21 +00:00

Maybe this was intentionally https://en.wikipedia.org/wiki/If_and_only_if

fyrchik commented

2023-08-10 14:25:05 +00:00

Poster

Rewrote it a bit.

fyrchik marked this conversation as resolved

aarifullin approved these changes 2023-08-10 08:58:46 +00:00

aarifullin left a comment

Very nice

fyrchik force-pushed check-contract-deletion from eddfb88735 to f4a0808e7f

2023-08-10 14:25:01 +00:00

Compare

fyrchik merged commit c6a7820363 into master

2023-08-10 17:13:08 +00:00

fyrchik deleted branch check-contract-deletion

2023-08-10 17:13:09 +00:00

fyrchik referenced this pull request

2023-08-10 17:15:26 +00:00

Allow to check whether a container was deleted #35

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-services-committers

TrueCloudLab/storage-services-developers

No Label

No Milestone

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#36