TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 16 Pull requests Projects Releases 2 Activity Actions

[#51] policy: Support Get and ListByPrefix methods #51

Merged
dkirillov merged 2 commits from dkirillov/frostfs-contract:feature/support_iam_operations into master 2024-09-04 19:51:17 +00:00
Conversation 0 Commits 2 Files changed 4 +64 -21
dkirillov commented 2023-11-17 08:06:50 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2023-11-17 08:06:50 +00:00
dkirillov changed title from WIP: [#XX] policy: Support Get and ListByPrefix methods to WIP: [#51] policy: Support Get and ListByPrefix methods 2023-11-17 08:06:58 +00:00
dkirillov force-pushed feature/support_iam_operations from 3c8596090b to 9103b4f04d 2023-11-17 08:07:19 +00:00 Compare
dkirillov force-pushed feature/support_iam_operations from 9103b4f04d to e4d7bd44a8 2023-11-17 08:16:35 +00:00 Compare
dkirillov changed title from WIP: [#51] policy: Support Get and ListByPrefix methods to [#51] policy: Support Get and ListByPrefix methods 2023-11-17 08:19:47 +00:00
dkirillov requested review from storage-core-committers 2023-11-17 08:19:53 +00:00
dkirillov requested review from storage-services-committers 2023-11-17 08:19:54 +00:00
dkirillov requested review from storage-core-developers 2023-11-17 08:19:54 +00:00
dkirillov requested review from storage-services-developers 2023-11-17 08:19:54 +00:00
alexvanin approved these changes 2023-11-17 08:28:25 +00:00
dkirillov force-pushed feature/support_iam_operations from e4d7bd44a8 to d6ec60f5b8 2023-11-17 08:45:18 +00:00 Compare
dkirillov force-pushed feature/support_iam_operations from d6ec60f5b8 to 567a160ec3 2023-11-17 08:51:20 +00:00 Compare
dkirillov force-pushed feature/support_iam_operations from 567a160ec3 to 0961e1fe7b 2023-11-17 08:54:11 +00:00 Compare
dkirillov force-pushed feature/support_iam_operations from 0961e1fe7b to 71d250a807 2023-11-17 09:11:07 +00:00 Compare
dkirillov reviewed 2023-11-17 10:06:40 +00:00
policy/policy_contract.go Outdated
@ -79,1 +90,4 @@
}
// ListChainsByPrefix list all chains for the provided kind and entity by prefix.
func ListChainsByPrefix(entity Kind, entityName, prefix string) [][]byte {
dkirillov commented 2023-11-17 10:06:40 +00:00
Author
Member
Copy link

I cannot decide should the return value be slice or iterator.
In IAM we are going to use two type entity name (managed and inline) so it seems we can have more that 2048 chains for every entityName. But probably as prototype we can keep slice

I cannot decide should the return value be slice or iterator. In IAM we are going to use two type entity name (`managed` and `inline`) so it seems we can have more that 2048 chains for every `entityName`. But probably as prototype we can keep slice
dkirillov force-pushed feature/support_iam_operations from 71d250a807 to 768bb9d9da 2023-11-17 11:36:03 +00:00 Compare
dkirillov force-pushed feature/support_iam_operations from 768bb9d9da to 5cc34f98e9 2023-11-17 11:37:22 +00:00 Compare
fyrchik reviewed 2023-11-17 11:50:13 +00:00
policy/policy_contract.go
@ -79,1 +90,4 @@
}
// ListChainsByPrefix list all chains for the provided kind and entity by prefix.
func ListChainsByPrefix(entity Kind, entityName, prefix string) [][]byte {
fyrchik commented 2023-11-17 11:49:52 +00:00
Owner
Copy link

ListChains already can list by prefix, what is the usecase for this?

`ListChains` already can list by prefix, what is the usecase for this?
dkirillov commented 2023-11-17 11:57:43 +00:00
Author
Member
Copy link

For i Kind

Line 16 in dd59193
IAM = 'i'

For `i` Kind https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/dd5919348da9731f24504e7bc485516c2ba5f11c/policy/policy_contract.go#L16
dstepanov-yadro commented 2023-11-20 09:18:02 +00:00
Member
Copy link

So looks like you can just edit ListChains method definition or edit ListChains method implementation to use ListChainsByPrefix method.

So looks like you can just edit `ListChains` method definition or edit `ListChains` method implementation to use `ListChainsByPrefix` method.
👍 1
dkirillov force-pushed feature/support_iam_operations from 663c53da84 to 20f86e96b2 2023-11-20 12:43:25 +00:00 Compare
aarifullin approved these changes 2023-11-21 10:12:07 +00:00
dstepanov-yadro approved these changes 2023-11-21 10:39:19 +00:00
pogpp approved these changes 2023-11-21 12:50:24 +00:00
fyrchik approved these changes 2023-11-22 07:53:59 +00:00
acid-ant approved these changes 2023-11-22 08:33:39 +00:00
dkirillov merged commit 20f86e96b2 into master 2023-11-22 08:35:24 +00:00
dkirillov deleted branch feature/support_iam_operations 2023-11-22 08:35:25 +00:00
dkirillov referenced this pull request from a commit 2023-11-22 08:35:27 +00:00
[#51] policy: Fix tests
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
aarifullin
dstepanov-yadro
pogpp
fyrchik
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
7 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#51
No description provided.
Delete branch "dkirillov/frostfs-contract:feature/support_iam_operations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?