frostfsid: allow empty namespaces #58

dkirillov · 2023-12-07T12:03:56Z

dkirillov commented

2023-12-07 12:03:56 +00:00

No description provided.

dkirillov self-assigned this 2023-12-07 12:03:56 +00:00

dkirillov added 2 commits 2023-12-07 12:03:58 +00:00

[#48 ] frostfsid: Support empty namespaces 12a34fa777

Require ns to create subject.
Since we don't allow move subject from one ns to another -
drop add/remove subject to/from namespace

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

[#48 ] frostfsid: add GetSubjectByName method

DCO action / DCO (pull_request) Successful in 1m4s

Details

Tests / Tests (1.19) (pull_request) Successful in 1m39s

Details

Tests / Tests (1.20) (pull_request) Successful in 1m40s

Details

46a0c79add

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

requested reviews from storage-core-committers, storage-core-developers, storage-services-committers, storage-services-developers

2023-12-07 12:04:30 +00:00

dstepanov-yadro approved these changes 2023-12-07 13:02:44 +00:00

fyrchik reviewed 2023-12-07 15:08:35 +00:00

frostfsid/frostfsid_contract.go

					
				@ -368,0 +357,4 @@

					it := storage.Find(ctx, groupPrefixFromHash(nsHash), storage.KeysOnly|storage.RemovePrefix)

					for iterator.Next(it) {

						groupHash := iterator.Value(it).([]byte)

						data := storage.Get(ctx, groupSubjectKeyFromHashes(nsHash, groupHash, addr)).([]byte)

fyrchik commented

2023-12-07 15:08:23 +00:00

We get data here and override it in the if is this intentional?

We get data here and override it in the `if` is this intentional?

dkirillov commented

2023-12-07 15:15:43 +00:00

It doesn't matter. We use only data that we got in if

It doesn't matter. We use only `data` that we got in `if`

frostfsid/frostfsid_contract.go

					
				@ -743,4 +665,2 @@

					storage.Put(ctx, nSubjKey, []byte{1})

					gKey := groupKey(subject.Namespace, groupID)

					data = storage.Get(ctx, gKey).([]byte)

fyrchik commented

2023-12-07 15:06:56 +00:00

Can we use common.GetSerialized?

Can we use `common.GetSerialized`?

dkirillov commented

2023-12-07 15:19:06 +00:00

Do you mean create new function in common package?

func GetSerialized(key []byte) any {
	ctx := storage.GetReadOnlyContext()
	data := storage.Get(ctx, key).([]byte)
	if data == nil {
		panic("not found")
	}

	return std.Deserialize(data)
}

Do you mean create new function in `common` package? ```golang func GetSerialized(key []byte) any { ctx := storage.GetReadOnlyContext() data := storage.Get(ctx, key).([]byte) if data == nil { panic("not found") } return std.Deserialize(data) } ```

fyrchik commented

2023-12-07 15:27:31 +00:00

My bad, we have SetSerialized, thought GetSerialized is there too.

My bad, we have `SetSerialized`, thought `GetSerialized` is there too.