Add multi-level container domain name support #60

Merged
fyrchik merged 1 commit from elebedeva/frostfs-contract:fix-container-domain into master 2023-12-13 12:43:07 +00:00
Member

Close

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #56 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva force-pushed fix-container-domain from b56b74cb2d to 6f0764d013 2023-12-12 17:31:29 +00:00 Compare
elebedeva force-pushed fix-container-domain from 6f0764d013 to 7d44583ee3 2023-12-13 10:33:20 +00:00 Compare
elebedeva force-pushed fix-container-domain from 7d44583ee3 to 281ce322c7 2023-12-13 10:45:54 +00:00 Compare
elebedeva changed title from WIP: Add multi-level container domain name support to Add multi-level container domain name support 2023-12-13 10:49:51 +00:00
elebedeva requested review from r.loginov 2023-12-13 10:55:38 +00:00
elebedeva requested review from storage-core-committers 2023-12-13 10:55:38 +00:00
elebedeva requested review from storage-core-developers 2023-12-13 10:55:41 +00:00
elebedeva requested review from storage-services-developers 2023-12-13 10:55:45 +00:00
elebedeva requested review from storage-services-committers 2023-12-13 10:56:04 +00:00
acid-ant approved these changes 2023-12-13 11:51:01 +00:00
dkirillov reviewed 2023-12-13 12:06:19 +00:00
@ -232,3 +232,3 @@
return true
}
return parentExpired(ctx, 0, fragments)
if parentExpired(ctx, 1, fragments) {
Member

It seems now parentExpired always accepts the 1 as the second arg. Should we drop this arg at all?

It seems now `parentExpired` always accepts the `1` as the second arg. Should we drop this arg at all?
Author
Member

fixed

fixed
dkirillov marked this conversation as resolved
dkirillov reviewed 2023-12-13 12:06:24 +00:00
fyrchik reviewed 2023-12-13 12:14:05 +00:00
fyrchik left a comment
Owner

besides mentined comments, LGTM

besides mentined comments, LGTM
@ -334,6 +334,8 @@ func TestNNSIsAvailable(t *testing.T) {
"myemail@frostfs.info", refresh, retry, expire, ttl)
c.Invoke(t, false, "isAvailable", "domain.com")
c.Invoke(t, true, "isAvailable", "dom.domain.com")
Owner

The problem in case was for Register, could you also add an explicit test for it?

The problem in case was for `Register`, could you also add an explicit test for it?
Author
Member

added

added
fyrchik marked this conversation as resolved
elebedeva force-pushed fix-container-domain from 281ce322c7 to 4dcb575caa 2023-12-13 12:22:33 +00:00 Compare
dkirillov approved these changes 2023-12-13 12:26:26 +00:00
alexvanin approved these changes 2023-12-13 12:33:22 +00:00
fyrchik approved these changes 2023-12-13 12:43:02 +00:00
fyrchik merged commit 4dcb575caa into master 2023-12-13 12:43:07 +00:00
elebedeva deleted branch fix-container-domain 2023-12-13 12:43:56 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#60
No description provided.