TrueCloudLab/frostfs-contract
22
0
Fork 19
Code Issues 12 Pull requests 1 Projects Releases 2 Activity Actions

frostfsid: Support proxy #63

Merged
dkirillov merged 1 commit from dkirillov/frostfs-contract:feature/frostfsid-support_proxy_client into master 2023-12-19 09:56:34 +00:00
Conversation 1 Commits 1 Files changed 2 +26 -5
dkirillov commented 2023-12-15 14:05:20 +00:00
Member
Copy link

Should be merged after #62

Should be merged after #62
dkirillov self-assigned this 2023-12-15 14:05:20 +00:00
dkirillov force-pushed feature/frostfsid-support_proxy_client from 55e9cc97d0 to 49d1f38ed8 2023-12-15 14:14:04 +00:00 Compare
dkirillov force-pushed feature/frostfsid-support_proxy_client from 49d1f38ed8 to 338226e818 2023-12-15 14:20:54 +00:00 Compare
dkirillov force-pushed feature/frostfsid-support_proxy_client from 338226e818 to 1d83391e10 2023-12-15 14:23:25 +00:00 Compare
dkirillov changed title from WIP: [#XX] frostfsid: Support proxy to WIP: frostfsid: Support proxy 2023-12-15 14:24:07 +00:00
dkirillov requested review from storage-core-developers 2023-12-15 14:25:08 +00:00
dkirillov requested review from storage-core-committers 2023-12-15 14:25:08 +00:00
dkirillov requested review from storage-services-committers 2023-12-15 14:25:09 +00:00
dkirillov requested review from storage-services-developers 2023-12-15 14:25:09 +00:00
dkirillov changed title from WIP: frostfsid: Support proxy to frostfsid: Support proxy 2023-12-15 14:25:15 +00:00
fyrchik commented 2023-12-15 14:27:36 +00:00
Owner
Copy link

The "best" possible scopes for proxy actor in this case would be CustomContracts: <policy contract hash>. This way we can use it's signature inside the policy contract but not anywhere else. Probably, this <policy contract hash> should be customized.
However, for simple scenarios, CalledByEntry is also enough -- it covers 99% of the usecases (call method and persist).

The "best" possible scopes for proxy actor in this case would be `CustomContracts: <policy contract hash>`. This way we can use it's signature _inside_ the policy contract but not anywhere else. Probably, this `<policy contract hash>` should be customized. However, for simple scenarios, `CalledByEntry` is also enough -- it covers 99% of the usecases (call method and persist).
dkirillov force-pushed feature/frostfsid-support_proxy_client from 1d83391e10 to 71a456aafc 2023-12-15 14:46:45 +00:00 Compare
dkirillov force-pushed feature/frostfsid-support_proxy_client from 71a456aafc to 07cd3077f4 2023-12-18 08:31:07 +00:00 Compare
dkirillov force-pushed feature/frostfsid-support_proxy_client from 07cd3077f4 to bce7ef18c8 2023-12-18 08:44:00 +00:00 Compare
pogpp approved these changes 2023-12-18 09:20:58 +00:00
alexvanin approved these changes 2023-12-18 10:20:17 +00:00
acid-ant approved these changes 2023-12-19 07:41:33 +00:00
dkirillov merged commit bce7ef18c8 into master 2023-12-19 09:56:34 +00:00
dkirillov deleted branch feature/frostfsid-support_proxy_client 2023-12-19 09:56:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
alexvanin
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#63
No description provided.
Delete branch "dkirillov/frostfs-contract:feature/frostfsid-support_proxy_client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?