TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 16 Pull requests Projects Releases 2 Activity Actions

Support IteratorChainsByPrefix method #70

Merged
fyrchik merged 1 commit from achuprov/frostfs-contract:feature/add_iterator_chains into master 2024-01-26 14:43:52 +00:00
Conversation 2 Commits 1 Files changed 4 +49 -1
achuprov commented 2024-01-15 13:31:09 +00:00
Member
Copy link

Close #66

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #66 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2024-01-15 13:33:38 +00:00
achuprov requested review from storage-core-developers 2024-01-15 13:33:38 +00:00
achuprov force-pushed feature/add_iterator_chains from 161d3055d0 to 4de205e2c9 2024-01-15 13:34:46 +00:00 Compare
achuprov commented 2024-01-15 13:35:44 +00:00
Author
Member
Copy link

fixed police -> policy

fixed `police` -> `policy`
dstepanov-yadro approved these changes 2024-01-15 13:48:33 +00:00
dkirillov commented 2024-01-15 14:12:44 +00:00
Member
Copy link

Don't we need to re-generate clients?

Don't we need to re-generate clients?
achuprov force-pushed feature/add_iterator_chains from 4de205e2c9 to f121f05897 2024-01-15 14:33:34 +00:00 Compare
dkirillov approved these changes 2024-01-15 14:44:42 +00:00
aarifullin approved these changes 2024-01-16 07:31:04 +00:00
acid-ant approved these changes 2024-01-16 07:43:38 +00:00
fyrchik reviewed 2024-01-26 14:31:02 +00:00
tests/policy_test.go Outdated
@ -106,0 +122,4 @@
for i := range expected {
bytesPolicy, err := policys[i].TryBytes()
require.NoError(t, err)
require.True(t, bytes.Equal(expected[i], bytesPolicy))
fyrchik commented 2024-01-26 14:31:01 +00:00
Owner
Copy link

I believe require.Equal works on byte slices.

I believe `require.Equal` works on byte slices.
fyrchik reviewed 2024-01-26 14:31:06 +00:00
tests/policy_test.go Outdated
@ -106,0 +122,4 @@
for i := range expected {
bytesPolicy, err := policys[i].TryBytes()
require.NoError(t, err)
require.True(t, bytes.Equal(expected[i], bytesPolicy))
fyrchik commented 2024-01-26 14:31:06 +00:00
Owner
Copy link

I believe require.Equal works on byte slices.

I believe `require.Equal` works on byte slices.
fyrchik approved these changes 2024-01-26 14:31:58 +00:00
achuprov force-pushed feature/add_iterator_chains from f121f05897 to dc60ea03af 2024-01-26 14:40:18 +00:00 Compare
achuprov force-pushed feature/add_iterator_chains from dc60ea03af to 93781f1149 2024-01-26 14:41:29 +00:00 Compare
fyrchik merged commit 93781f1149 into master 2024-01-26 14:43:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
dkirillov
aarifullin
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#70
No description provided.
Delete branch "achuprov/frostfs-contract:feature/add_iterator_chains"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?