TrueCloudLab/frostfs-dev-env
42
0
Fork 18
Code Issues 15 Pull requests Releases Activity Actions

Add prometheus #16

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-dev-env:prometheus into master 2023-07-26 21:08:04 +00:00
Conversation 0 Commits 1 Files changed 3 +12
dstepanov-yadro commented 2023-04-07 09:34:46 +00:00
Member
Copy link

Run prometheus to query metrics

Run prometheus to query metrics
dstepanov-yadro force-pushed prometheus from 557df54455 to f33dc105e4 2023-04-07 09:35:47 +00:00 Compare
dstepanov-yadro force-pushed prometheus from f33dc105e4 to a79e30ffa4 2023-04-07 09:37:14 +00:00 Compare
requested reviews from storage-core-committers, storage-core-developers 2023-04-07 09:37:32 +00:00
fyrchik reviewed 2023-04-07 09:49:11 +00:00
services/prometheus/prometheus.yml Outdated
@ -0,0 +4,4 @@
scrape_configs:
- job_name: 'node'
static_configs:
- targets: ['s01.frostfs.devenv:9090', 's02.frostfs.devenv:9090', 's03.frostfs.devenv:9090', 's04.frostfs.devenv:9090']
fyrchik commented 2023-04-07 09:49:11 +00:00
Owner
Copy link

I think, s3 and neo-go could be useful too?

I think, s3 and neo-go could be useful too?
👍 1
alexvanin commented 2023-04-07 09:58:26 +00:00
Owner
Copy link

http and s3 metrics are disabled by default, but it would be nice to enable it and collect in prometheus as well.

See:

http and s3 metrics are disabled by default, but it would be nice to enable it and collect in prometheus as well. See: - https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/src/branch/master/docs/gate-configuration.md#prometheus-section - https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/branch/master/docs/configuration.md#prometheus-section
dstepanov-yadro commented 2023-04-07 15:57:12 +00:00
Author
Member
Copy link

Done

Done
fyrchik marked this conversation as resolved
aarifullin approved these changes 2023-04-07 11:46:04 +00:00
acid-ant approved these changes 2023-04-07 12:19:22 +00:00
dstepanov-yadro force-pushed prometheus from a79e30ffa4 to 121cd808bd 2023-04-07 15:56:58 +00:00 Compare
fyrchik approved these changes 2023-04-07 17:27:30 +00:00
services/http_gate/cfg/config.yml Outdated
@ -1,5 +1,9 @@
logger:
level: debug
fyrchik commented 2023-04-07 17:26:28 +00:00
Owner
Copy link

Can we have a separate commit for this enabling prometheus in services?

Can we have a separate commit for this enabling prometheus in services?
dstepanov-yadro commented 2023-04-10 06:42:02 +00:00
Author
Member
Copy link

Done

Done
fyrchik marked this conversation as resolved
services/prometheus/prometheus.yml Outdated
@ -0,0 +13,4 @@
- targets: ['rest.frostfs.devenv:9090']
- job_name: 's3-gw'
static_configs:
- targets: ['s3.frostfs.devenv:9090']
fyrchik commented 2023-04-07 17:26:55 +00:00
Owner
Copy link

I've just stumbled upon that s3 and s03 look too similar.

I've just stumbled upon that `s3` and `s03` look too similar.
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed prometheus from 121cd808bd to 11ff8a81cc 2023-04-10 06:41:46 +00:00 Compare
fyrchik merged commit 11ff8a81cc into master 2023-04-10 12:58:40 +00:00
fyrchik referenced this pull request from a commit 2023-04-10 12:58:40 +00:00
[#16] dev-env: Add prometheus
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-dev-env#16
No description provided.
Delete branch "dstepanov-yadro/frostfs-dev-env:prometheus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?