TrueCloudLab
/
frostfs-dev-env
38
0
Fork 15
Code Issues 15 Pull Requests 1 Actions Releases Activity

[#47] grafana: Don't bind port to localhost #54

Merged
dkirillov merged 2 commits from dkirillov/frostfs-dev-env:feature/47-dont_expose_grafana_port into master 2023-10-06 08:04:12 +00:00
Conversation 2 Commits 2 Files Changed 2
dkirillov commented 2023-08-29 09:47:24 +00:00
Collaborator

close #47

close #47
dkirillov self-assigned this 2023-08-29 09:47:24 +00:00
dkirillov requested review from storage-core-committers 2023-08-29 09:47:35 +00:00
dkirillov requested review from storage-core-developers 2023-08-29 09:47:36 +00:00
dkirillov requested review from storage-services-committers 2023-08-29 09:47:37 +00:00
dkirillov requested review from storage-services-developers 2023-08-29 09:47:38 +00:00
pogpp approved these changes 2023-08-29 12:00:13 +00:00
dstepanov-yadro requested changes 2023-08-29 14:00:51 +00:00
services/prometheus/docker-compose.yml Outdated
@ -16,4 +16,2 @@
command:
- --config.file=/etc/prometheus/prometheus.yml
ports:
- '9090:9090'
dstepanov-yadro commented 2023-08-29 14:00:48 +00:00
Collaborator

Have you tested metrics/grafana after this fix? How does it work? Storage config contains:

# Application metrics section
prometheus:
  enabled: true
  address: :9090  # Server address
  shutdown_timeout: 15s  # Timeout for metrics HTTP server graceful shutdown
Have you tested metrics/grafana after this fix? How does it work? Storage config contains: ``` # Application metrics section prometheus: enabled: true address: :9090 # Server address shutdown_timeout: 15s # Timeout for metrics HTTP server graceful shutdown ```
dkirillov commented 2023-08-30 06:52:11 +00:00
Poster
Collaborator

I checked go runtime metrics from storage nodes
image

I checked go runtime metrics from storage nodes ![image](/attachments/8aac0be3-5f9d-42ab-bf66-65d73d4d0541)
image.png
356 KiB
dstepanov-yadro commented 2023-09-01 12:59:53 +00:00
Collaborator

I checked go runtime metrics from storage nodes

Then i don't understand how it works :(

> I checked go runtime metrics from storage nodes Then i don't understand how it works :(
dkirillov force-pushed feature/47-dont_expose_grafana_port from e0a13dcf1f to de8b58911e 2023-10-06 07:43:10 +00:00 Compare
dstepanov-yadro approved these changes 2023-10-06 07:46:51 +00:00
pogpp approved these changes 2023-10-06 07:48:21 +00:00
dkirillov merged commit de8b58911e into master 2023-10-06 08:04:12 +00:00
dkirillov deleted branch feature/47-dont_expose_grafana_port 2023-10-06 08:04:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
pogpp
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dkirillov
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-dev-env#54
There is no content yet.
Delete Branch "dkirillov/frostfs-dev-env:feature/47-dont_expose_grafana_port"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?