TrueCloudLab/frostfs-dev-env
41
0
Fork 17
Code Issues 16 Pull requests 2 Releases Activity Actions

Makefile: Add subjects for storage and client wallets to FrostfsID #75

Merged
fyrchik merged 1 commit from aarifullin/frostfs-dev-env:feat/fidsubj_makefile into master 2024-08-16 07:46:12 +00:00
Conversation 0 Commits 1 Files changed 1 +6 -1
aarifullin commented 2024-08-02 11:59:35 +00:00
Member
Copy link

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin added 1 commit 2024-08-02 11:59:40 +00:00
[#XX] Makefile: Add subjects for storage and client wallets to FrostfsID
All checks were successful
DCO action / DCO (pull_request) Successful in 27s
Details
79952e82e0 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed feat/fidsubj_makefile from 79952e82e0 to 4b55eb102e 2024-08-02 11:59:58 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-08-02 12:00:08 +00:00
aarifullin requested review from storage-core-developers 2024-08-02 12:00:09 +00:00
aarifullin requested review from storage-services-committers 2024-08-02 12:00:14 +00:00
aarifullin requested review from storage-services-developers 2024-08-02 12:00:15 +00:00
aarifullin reviewed 2024-08-02 12:02:41 +00:00
Makefile Outdated
@ -87,2 +92,3 @@
done
@echo "FrostFS sidechain environment is deployed"
@echo "Create frostfsid subject for ./wallets/wallet.json" \
&& subj_key=`neo-go wallet dump-keys -w ./wallets/wallet.json | head -2 | tail -1` \
aarifullin commented 2024-08-02 12:02:41 +00:00
Author
Member
Copy link

We've got no neo-go in .vendor. So, it assumes that neo-go is installed separately.
Probably, this is not right for frostfs-dev-env bootup

The alternative way to get parsed script is:

cat wallets/wallet.json | jq -r '.accounts[0].contract.script' | base64 -d | tail -c+3 | xxd -p

(returns the same result)

WDYT?

We've got no `neo-go` in `.vendor`. So, it assumes that `neo-go` is installed separately. Probably, this is not right for `frostfs-dev-env` bootup The alternative way to get parsed script is: ``` cat wallets/wallet.json | jq -r '.accounts[0].contract.script' | base64 -d | tail -c+3 | xxd -p ``` (returns the same result) WDYT?
dstepanov-yadro commented 2024-08-02 15:19:29 +00:00
Member
Copy link

FrostfID subject is required to create containers. Neo-go or Frostfs-storage should not to create containers. So their wallets are not required to be stored in FrostfsID contract.

FrostfID subject is required to create containers. Neo-go or Frostfs-storage should not to create containers. So their wallets are not required to be stored in FrostfsID contract.
aarifullin commented 2024-08-05 09:44:53 +00:00
Author
Member
Copy link

Okay, I'll leave it only for client wallet. But the problem is that we need to get a subject key for this wallet

Okay, I'll leave it only for client wallet. But the problem is that we need to get a subject key for this wallet
aarifullin commented 2024-08-08 10:18:51 +00:00
Author
Member
Copy link

Fixed

Fixed
aarifullin marked this conversation as resolved
fyrchik reviewed 2024-08-02 12:55:58 +00:00
Makefile Outdated
@ -85,2 +85,4 @@
&& ./vendor/frostfs-adm -c frostfs-adm.yml morph refill-gas --storage-wallet $${f} --gas 10.0 \
|| die "Failed to transfer GAS to alphabet wallets"; \
echo "Create frostfsid subject for storage wallet $${f}" \
&& subj_key=`neo-go wallet dump-keys -w $${f} | head -2 | tail -1` \
fyrchik commented 2024-08-02 12:55:56 +00:00
Owner
Copy link

I think storage nodes are ok not being in the frostfsid, we have user wallet for containers.

I think storage nodes are ok not being in the frostfsid, we have user wallet for containers.
aarifullin commented 2024-08-02 13:30:52 +00:00
Author
Member
Copy link

OK.

But still WDYT about neo-go?

OK. But still WDYT about `neo-go`?
fyrchik commented 2024-08-05 12:34:45 +00:00
Owner
Copy link

using neo-go is more robust than jq + tail c+3

using neo-go is more robust than `jq + tail c+3`
aarifullin commented 2024-08-08 10:19:11 +00:00
Author
Member
Copy link

Got neo-go away, please, check

Got `neo-go` away, please, check
fyrchik commented 2024-08-08 10:31:43 +00:00
Owner
Copy link

Why, though? "robust" is a good thing.

Why, though? "robust" is a good thing.
dstepanov-yadro commented 2024-08-08 13:42:22 +00:00
Member
Copy link

Then neo-go should be vendored.

Then neo-go should be vendored.
aarifullin commented 2024-08-08 14:01:45 +00:00
Author
Member
Copy link
  1. I mistook "robust" for "giant" but you problably meant "sturdy"
  2. @dstepanov-yadro is right. In this case we need to introduce neo-go binary in .env along with
...
# FrostFS ADM tool binary
FROSTFS_ADM_VERSION=498f9955ea
FROSTFS_ADM_URL=https://http.t5.fs.neo.org/7sm9csjtRLpr4c9QD55q9JJM73v79ohuAhTzP4fYRHFz/CjV4S6ENzo2FLK4KxXZHHNW4veR1ATtynGY6Mc1xQ6RB
#FROSTFS_ADM_PATH=/path/to/frostfs-adm-binary
...

to get it vendored

So, we need to upload it to somewhere. Once, we had a discussion and we didn't agree on uploading to http.t5.fs.neo.org (I may mistake)

1. I mistook "robust" for "giant" but you problably meant "sturdy" 2. @dstepanov-yadro is right. In this case we need to introduce `neo-go` binary in `.env` along with ```bash ... # FrostFS ADM tool binary FROSTFS_ADM_VERSION=498f9955ea FROSTFS_ADM_URL=https://http.t5.fs.neo.org/7sm9csjtRLpr4c9QD55q9JJM73v79ohuAhTzP4fYRHFz/CjV4S6ENzo2FLK4KxXZHHNW4veR1ATtynGY6Mc1xQ6RB #FROSTFS_ADM_PATH=/path/to/frostfs-adm-binary ... ``` to get it vendored So, we need to upload it to *somewhere*. Once, we had a discussion and we didn't agree on uploading to `http.t5.fs.neo.org` (I may mistake)
fyrchik commented 2024-08-08 14:09:54 +00:00
Owner
Copy link

We already have a docker image for neo-go, right?
Can we use it?

We already have a docker image for neo-go, right? Can we use it?
👀 1
aarifullin commented 2024-08-09 13:45:14 +00:00
Author
Member
Copy link

We already have a docker image for neo-go, right?

That's really a brilliant idea. Fixed that

> We already have a docker image for neo-go, right? That's really a brilliant idea. Fixed that
aarifullin force-pushed feat/fidsubj_makefile from 4b55eb102e to 28916ea278 2024-08-08 10:18:43 +00:00 Compare
aarifullin force-pushed feat/fidsubj_makefile from 28916ea278 to e3201f89d3 2024-08-09 13:45:08 +00:00 Compare
fyrchik approved these changes 2024-08-09 14:04:24 +00:00
acid-ant approved these changes 2024-08-09 15:08:39 +00:00
achuprov approved these changes 2024-08-09 16:07:20 +00:00
aarifullin force-pushed feat/fidsubj_makefile from e3201f89d3 to d03be14312 2024-08-16 07:42:11 +00:00 Compare
aarifullin requested review from fyrchik 2024-08-16 07:42:16 +00:00
aarifullin requested review from acid-ant 2024-08-16 07:42:18 +00:00
aarifullin requested review from achuprov 2024-08-16 07:42:19 +00:00
fyrchik approved these changes 2024-08-16 07:46:08 +00:00
fyrchik merged commit d03be14312 into master 2024-08-16 07:46:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
achuprov
fyrchik
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-dev-env#75
No description provided.
Delete branch "aarifullin/frostfs-dev-env:feat/fidsubj_makefile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?