[#117] Fix FrostFS interface usage

HTTP Gateway expects io.Reader to work with
payload, however `WithPayload` flag reads whole
payload into header object.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>

internal/frostfs/frostfs.go

@@ -85,43 +85,16 @@ func (x *FrostFS) ReadObject(ctx context.Context, prm handler.PrmObjectRead) (*h
 		prmGet.UseBearer(*prm.BearerToken)
 	}
 
-	if prm.WithHeader {
+	// The code below must be reworked. It was copied from frostfs-s3-gw
-		if prm.WithPayload {
+	// to create similar mocks for unit and fuzzing tests.
-			res, err := x.pool.GetObject(ctx, prmGet)
+	//
-			if err != nil {
+	// However, this code was changed due to specific of expected responses
-				return nil, handleObjectError("init full object reading via connection pool", err)
+	// from HTTP gateway. HTTP Gateway requires two types of responses:
-			}
+	// * payload as io.Reader + HEAD request
+	// * only payload as io.Reader
+	// Therefore all unused params were deleted and code was simplified.
 
-			defer res.Payload.Close()
+	if prm.PayloadRange[0]+prm.PayloadRange[1] == 0 {
-
-			payload, err := io.ReadAll(res.Payload)
-			if err != nil {
-				return nil, handleObjectError("read full object payload", err)
-			}
-
-			res.Header.SetPayload(payload)
-
-			return &handler.ObjectPart{
-				Head: &res.Header,
-			}, nil
-		}
-
-		var prmHead pool.PrmObjectHead
-		prmHead.SetAddress(prm.Address)
-
-		if prm.BearerToken != nil {
-			prmHead.UseBearer(*prm.BearerToken)
-		}
-
-		hdr, err := x.pool.HeadObject(ctx, prmHead)
-		if err != nil {
-			return nil, handleObjectError("read object header via connection pool", err)
-		}
-
-		return &handler.ObjectPart{
-			Head: &hdr,
-		}, nil
-	} else if prm.PayloadRange[0]+prm.PayloadRange[1] == 0 {
 		res, err := x.pool.GetObject(ctx, prmGet)
 		if err != nil {
 			return nil, handleObjectError("init full payload range reading via connection pool", err)
@@ -129,6 +102,7 @@ func (x *FrostFS) ReadObject(ctx context.Context, prm handler.PrmObjectRead) (*h
 
 		return &handler.ObjectPart{
 			Payload: res.Payload,
+			Head:    &res.Header,
 		}, nil
 	}
 

internal/handler/download.go

@@ -157,9 +157,7 @@ func (h *Handler) zipObject(ctx context.Context, zipWriter *zip.Writer, addr oid
 		PrmAuth: PrmAuth{
 			BearerToken: btoken,
 		},
-		Address:     addr,
+		Address: addr,
-		WithHeader:  true,
-		WithPayload: true,
 	}
 
 	resGet, err := h.frostfs.ReadObject(ctx, prm)

internal/handler/handler.go

@@ -54,12 +54,6 @@ type PrmObjectRead struct {
 	// Address to read the object header from.
 	Address oid.Address
 
-	// Flag to read object header.
-	WithHeader bool
-
-	// Flag to read object payload. False overlaps payload range.
-	WithPayload bool
-
 	// Offset-length range of the object payload to be read.
 	PayloadRange [2]uint64
 }

internal/handler/head.go

@@ -33,8 +33,7 @@ func (h *Handler) headObject(ctx context.Context, req request, objectAddress oid
 		PrmAuth: PrmAuth{
 			BearerToken: btoken,
 		},
-		Address:    objectAddress,
+		Address: objectAddress,
-		WithHeader: true,
 	}
 
 	obj, err := h.frostfs.ReadObject(ctx, prm)
@@ -80,7 +79,6 @@ func (h *Handler) headObject(ctx context.Context, req request, objectAddress oid
 					BearerToken: btoken,
 				},
 				Address:      objectAddress,
-				WithPayload:  true,
 				PayloadRange: [2]uint64{0, sz},
 			}
 

internal/handler/reader.go

@@ -59,9 +59,7 @@ func (h *Handler) receiveFile(ctx context.Context, req request, objectAddress oi
 		PrmAuth: PrmAuth{
 			BearerToken: bearerToken(ctx),
 		},
-		Address:     objectAddress,
+		Address: objectAddress,
-		WithHeader:  true,
-		WithPayload: true,
 	}
 
 	rObj, err := h.frostfs.ReadObject(ctx, prm)