TrueCloudLab/frostfs-http-gw
14
1
Fork 17
Code Issues 7 Pull requests 3 Projects Releases 8 Activity Actions

Update Go version to 1.22 #132

Merged
alexvanin merged 1 commit from nzinkevich/frostfs-http-gw:update_go_122 into master 2024-08-30 06:54:45 +00:00
Conversation 5 Commits 1 Files changed 10 +16 -17
nzinkevich commented 2024-08-21 12:00:31 +00:00
Member
Copy link

Signed-off-by: Nikita Zinkevich n.zinkevich@yadro.com

Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
nzinkevich added 1 commit 2024-08-21 12:00:35 +00:00
Update Go version to 1.22
Some checks failed
/ Vulncheck (pull_request) Successful in 1m20s
Details
/ Builds (1.22) (pull_request) Successful in 1m38s
Details
/ Builds (1.23) (pull_request) Successful in 1m36s
Details
/ Lint (pull_request) Successful in 2m12s
Details
/ Tests (1.22) (pull_request) Successful in 1m40s
Details
/ Tests (1.23) (pull_request) Successful in 1m38s
Details
/ DCO (pull_request) Failing after 1m41s
Details
d85a047d0c 
Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
nzinkevich requested review from alexvanin 2024-08-21 12:00:56 +00:00
nzinkevich requested review from dkirillov 2024-08-21 12:00:57 +00:00
nzinkevich force-pushed update_go_122 from d85a047d0c to 1bd011c7c7 2024-08-21 12:33:56 +00:00 Compare
nzinkevich force-pushed update_go_122 from 1bd011c7c7 to 3e2b918a06 2024-08-21 12:38:55 +00:00 Compare
dkirillov commented 2024-08-21 12:52:43 +00:00
Member
Copy link

Please update CHANGELOG.md

Please update CHANGELOG.md
alexvanin approved these changes 2024-08-22 14:00:08 +00:00
nzinkevich force-pushed update_go_122 from 3e2b918a06 to 089deeb167 2024-08-23 07:02:36 +00:00 Compare
nzinkevich commented 2024-08-23 07:07:26 +00:00
Author
Member
Copy link

Update linters

Update linters
nzinkevich requested review from alexvanin 2024-08-23 07:07:32 +00:00
dkirillov commented 2024-08-23 07:52:43 +00:00
Member
Copy link

We have separate PR for update linters #133 🤔

We have separate PR for update linters https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/pulls/133 🤔
👍 1
nzinkevich force-pushed update_go_122 from 089deeb167 to 0e26aaf647 2024-08-23 10:20:38 +00:00 Compare
nzinkevich force-pushed update_go_122 from 0e26aaf647 to 269fda6d34 2024-08-23 10:24:45 +00:00 Compare
nzinkevich commented 2024-08-23 10:30:44 +00:00
Author
Member
Copy link

Is it okay that linters don't pass? It's required to set LINT_VERSION, however it was done in separate PR #133

Is it okay that linters don't pass? It's required to set LINT_VERSION, however it was done in separate PR #133
elebedeva commented 2024-08-23 10:49:47 +00:00
Member
Copy link

Is it okay that linters don't pass? It's required to set LINT_VERSION, however it was done in separate PR #133

I believe it's not, so updating linter version in this PR is a good idea. I'll close #133.

> Is it okay that linters don't pass? It's required to set LINT_VERSION, however it was done in separate PR #133 I believe it's not, so updating linter version in this PR is a good idea. I'll close #133.
nzinkevich force-pushed update_go_122 from 269fda6d34 to 2ed664dfdb 2024-08-23 13:41:11 +00:00 Compare
elebedeva reviewed 2024-08-23 13:56:29 +00:00
Makefile Outdated
@ -31,3 +31,3 @@
.PHONY: debpackage debclean
# Make all binaries
# Make uall binaries
elebedeva commented 2024-08-23 13:56:29 +00:00
Member
Copy link

What's uall?

What's `uall`?
elebedeva reviewed 2024-08-23 14:00:18 +00:00
.forgejo/workflows/tests.yml Outdated
@ -39,3 +39,3 @@
- name: Run tests
run: make test
run: make test
elebedeva commented 2024-08-23 14:00:18 +00:00
Member
Copy link

What's changed here?

What's changed here?
dkirillov commented 2024-08-23 14:01:37 +00:00
Member
Copy link

New line I suppose

New line I suppose
👍 1
nzinkevich force-pushed update_go_122 from 2ed664dfdb to 69b68589d0 2024-08-29 05:30:36 +00:00 Compare
nzinkevich force-pushed update_go_122 from 69b68589d0 to 151e5bc1c8 2024-08-29 07:44:53 +00:00 Compare
dkirillov approved these changes 2024-08-29 11:05:55 +00:00
alexvanin approved these changes 2024-08-30 06:54:36 +00:00
alexvanin merged commit 151e5bc1c8 into master 2024-08-30 06:54:45 +00:00
alexvanin referenced this pull request from a commit 2024-08-30 06:54:45 +00:00
[#132] Update Go version
alexvanin deleted branch update_go_122 2024-08-30 06:54:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#132
No description provided.
Delete branch "nzinkevich/frostfs-http-gw:update_go_122"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?