TrueCloudLab/frostfs-http-gw
16
1
Fork 17
Code Issues 9 Pull requests 2 Projects Releases 9 Activity Actions

lint: Update golangci-lint to v1.60 and fix issues #133

Closed
elebedeva wants to merge 1 commit from elebedeva/frostfs-http-gw:feat/lint-update-version into master
pull from: elebedeva/frostfs-http-gw:feat/lint-update-version
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files changed 5 +7 -11
elebedeva commented 2024-08-22 17:42:53 +00:00
Member
Copy link

Closes a part of TrueCloudLab/frostfs-node#1280

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Closes a part of TrueCloudLab/frostfs-node#1280 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva added 1 commit 2024-08-22 17:42:57 +00:00
[#133] lint: Update golangci-lint to v1.60 and fix issues
Some checks reported warnings
/ Builds (1.21) (pull_request) Has been cancelled
Details
/ Builds (1.22) (pull_request) Has been cancelled
Details
/ DCO (pull_request) Has been cancelled
Details
/ Lint (pull_request) Has been cancelled
Details
/ Tests (1.21) (pull_request) Has been cancelled
Details
/ Tests (1.22) (pull_request) Has been cancelled
Details
/ Vulncheck (pull_request) Has been cancelled
Details
26e683f90d 
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
dkirillov reviewed 2024-08-23 06:23:51 +00:00
internal/handler/reader_test.go Outdated
@ -36,3 +36,3 @@
t.Run(tc.Name, func(t *testing.T) {
contentType, data, err := readContentType(uint64(len(tc.Expected)),
func(sz uint64) (io.Reader, error) {
func(_ uint64) (io.Reader, error) {
dkirillov commented 2024-08-23 06:23:51 +00:00
Member
Copy link

It's better don't use _

func(uint64) (io.Reader, error) {
It's better don't use `_` ```golang func(uint64) (io.Reader, error) { ```
elebedeva commented 2024-08-23 09:28:06 +00:00
Author
Member
Copy link

Fixed!

Fixed!
dkirillov reviewed 2024-08-23 06:25:21 +00:00
.pre-commit-config.yaml Outdated
@ -30,11 +30,6 @@ repos:
hooks:
- id: shellcheck
- repo: https://github.com/golangci/golangci-lint
dkirillov commented 2024-08-23 06:25:21 +00:00
Member
Copy link

Do we drop this because we always use local golangci-lint?

Do we drop this because we always use local `golangci-lint`?
elebedeva commented 2024-08-23 09:27:42 +00:00
Author
Member
Copy link

Yes, I don't see the need to run golangci-lint two times in a row.

Yes, I don't see the need to run `golangci-lint` two times in a row.
elebedeva force-pushed feat/lint-update-version from 26e683f90d to c6875030f6 2024-08-23 09:26:55 +00:00 Compare
elebedeva requested review from storage-services-committers 2024-08-23 09:28:52 +00:00
elebedeva requested review from storage-services-developers 2024-08-23 09:28:52 +00:00
dkirillov approved these changes 2024-08-23 09:53:21 +00:00
elebedeva commented 2024-08-23 10:51:49 +00:00
Author
Member
Copy link

Update golangci-lint is done in PR #132, closing this one.

Update golangci-lint is done in PR #132, closing this one.
elebedeva closed this pull request 2024-08-23 10:51:56 +00:00
Some checks reported warnings
/ Builds (1.21) (pull_request) Has been cancelled
Details
/ Builds (1.22) (pull_request) Has been cancelled
Details
/ DCO (pull_request) Has been cancelled
Details
/ Lint (pull_request) Has been cancelled
Details
/ Tests (1.21) (pull_request) Has been cancelled
Details
/ Tests (1.22) (pull_request) Has been cancelled
Details
/ Vulncheck (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#133
No description provided.
Delete branch "elebedeva/frostfs-http-gw:feat/lint-update-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?