TrueCloudLab/frostfs-http-gw
17
1
Fork 18
Code Issues 9 Pull requests 1 Projects Releases 16 Activity Actions

[#219] Use zaptest.Logger #219

Merged
alexvanin merged 1 commit from dkirillov/frostfs-http-gw:feature/suppress_log_in_succeded_tests into master 2025-02-24 09:34:56 +00:00
Conversation 0 Commits 1 Files changed 3 +14 -24
dkirillov commented 2025-02-21 13:11:22 +00:00
Member
Copy link

Use zaptest to get logs which get printed only if a test fails
or if you ran go test -v.

Dont use zaptest.Logger for fuzz otherwise ngfuzz/libfuzz crashes

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Similar to TrueCloudLab/frostfs-s3-gw#646

Use zaptest to get logs which get printed only if a test fails or if you ran go test -v. Dont use zaptest.Logger for fuzz otherwise ngfuzz/libfuzz crashes Signed-off-by: Denis Kirillov <d.kirillov@yadro.com> Similar to https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/646
dkirillov self-assigned this 2025-02-21 13:11:22 +00:00
dkirillov added 1 commit 2025-02-21 13:11:23 +00:00
[#XX] Use zaptest.Logger
Some checks failed
/ DCO (pull_request) Failing after 29s
Details
/ Vulncheck (pull_request) Successful in 56s
Details
/ Builds (pull_request) Successful in 1m10s
Details
/ OCI image (pull_request) Successful in 1m27s
Details
/ Lint (pull_request) Successful in 2m15s
Details
/ Tests (pull_request) Successful in 1m8s
Details
/ Integration tests (pull_request) Successful in 6m0s
Details
2d10f852e3 
Use zaptest to get logs which get printed only if a test fails
or if you ran go test -v.

Dont use zaptest.Logger for fuzz otherwise ngfuzz/libfuzz crashes

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
requested reviews from storage-services-developers, storage-services-committers 2025-02-21 13:11:23 +00:00
dkirillov changed title from [#XX] Use zaptest.Logger to [#219] Use zaptest.Logger 2025-02-21 13:11:41 +00:00
dkirillov force-pushed feature/suppress_log_in_succeded_tests from 2d10f852e3 to a651b5823f 2025-02-21 13:12:02 +00:00 Compare
alexvanin added this to the v0.33.0 milestone 2025-02-24 09:25:11 +00:00
alexvanin reviewed 2025-02-24 09:27:03 +00:00
internal/handler/multipart_test.go
@ -93,3 +85,1 @@
}
file, err := fetchMultipartFile(logger, r, bound)
file, err := fetchMultipartFile(zap.NewNop(), r, bound)
alexvanin commented 2025-02-24 09:27:03 +00:00
Owner
Copy link

I think S3 uses zaptest.NewLogger() in TrueCloudLab/frostfs-s3-gw#646

Should we use Nop logger?

I think S3 uses `zaptest.NewLogger()` in https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/646 Should we use Nop logger?
alexvanin commented 2025-02-24 09:34:47 +00:00
Owner
Copy link

This is used in bench, then it makes sense.

This is used in bench, then it makes sense.
alexvanin marked this conversation as resolved
alexvanin approved these changes 2025-02-24 09:34:33 +00:00
alexvanin merged commit a651b5823f into master 2025-02-24 09:34:56 +00:00
alexvanin deleted branch feature/suppress_log_in_succeded_tests 2025-02-24 09:34:57 +00:00
alexvanin referenced this pull request from a commit 2025-02-24 09:34:58 +00:00
[#219] Use zaptest.Logger
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.33.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#219
No description provided.
Delete branch "dkirillov/frostfs-http-gw:feature/suppress_log_in_succeded_tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?