TrueCloudLab/frostfs-http-gw
17
1
Fork 18
Code Issues 11 Pull requests 4 Projects Releases 14 Activity Actions

[#76] Add go1.21 to CI #76

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-http-gw:feature/add_go1.21_to_ci into master 2023-08-31 11:49:48 +00:00
Conversation 0 Commits 1 Files changed 7 +7 -7
mbiryukova commented 2023-08-28 11:15:46 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2023-08-28 11:15:46 +00:00
fyrchik reviewed 2023-08-28 11:50:53 +00:00
.forgejo/workflows/builds.yml Outdated
@ -7,3 +7,3 @@
strategy:
matrix:
go_versions: [ '1.19', '1.20' ]
go_versions: [ '1.19', '1.20', '1.21' ]
fyrchik commented 2023-08-28 11:50:53 +00:00
Owner
Copy link

Shouldn't we remove 1.19 too?
We agreed to support the last 2 versions.

Shouldn't we remove 1.19 too? We agreed to support the last 2 versions.
👍 1
dkirillov commented 2023-08-28 11:53:43 +00:00
Member
Copy link

Probably we also should bump go version in go.mod

Probably we also should bump go version in [go.mod](https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/src/commit/cc69601b32a09290dae3ccdeab4eb39515251172/go.mod#L3)
alexvanin commented 2023-08-28 12:56:29 +00:00
Owner
Copy link

We should and we will.

We should and we will.
mbiryukova force-pushed feature/add_go1.21_to_ci from 347a5d723f to f24e85de40 2023-08-28 12:08:01 +00:00 Compare
requested reviews from storage-services-committers, storage-services-developers 2023-08-28 12:08:34 +00:00
dkirillov approved these changes 2023-08-28 12:38:37 +00:00
mbiryukova force-pushed feature/add_go1.21_to_ci from f24e85de40 to 890e26aad0 2023-08-30 10:44:21 +00:00 Compare
requested review from dkirillov 2023-08-30 11:14:55 +00:00
mbiryukova force-pushed feature/add_go1.21_to_ci from 890e26aad0 to b7fcc864e6 2023-08-30 14:13:10 +00:00 Compare
alexvanin reviewed 2023-08-31 11:23:51 +00:00
Dockerfile Outdated
@ -1,4 +1,4 @@
FROM golang:1.19-alpine as basebuilder
FROM golang:1.20-alpine as basebuilder
alexvanin commented 2023-08-31 11:23:51 +00:00
Owner
Copy link

Let's use latest go version for all our builds. For instance, storage node uses go1.21 for builds https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/.docker/Dockerfile.storage

Let's use latest go version for all our builds. For instance, storage node uses go1.21 for builds https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/.docker/Dockerfile.storage
mbiryukova force-pushed feature/add_go1.21_to_ci from b7fcc864e6 to 7d47e88e36 2023-08-31 11:36:32 +00:00 Compare
alexvanin approved these changes 2023-08-31 11:49:43 +00:00
alexvanin merged commit 7d47e88e36 into master 2023-08-31 11:49:48 +00:00
alexvanin deleted branch feature/add_go1.21_to_ci 2023-08-31 11:49:49 +00:00
alexvanin referenced this pull request from a commit 2023-08-31 11:49:50 +00:00
[#76] Add go1.21 to CI
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#76
No description provided.
Delete branch "mbiryukova/frostfs-http-gw:feature/add_go1.21_to_ci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?