TrueCloudLab/frostfs-http-gw
17
1
Fork 18
Code Issues 9 Pull requests 1 Projects Releases 16 Activity Actions

[#155] Support: fix download of multipart objects #155

Merged
alexvanin merged 1 commit from nzinkevich/frostfs-http-gw:support/v0.30_fix_multipart into support/v0.30 2024-10-26 11:30:13 +00:00
Conversation 2 Commits 1 Files changed 14 +550 -73
nzinkevich commented 2024-10-18 10:06:36 +00:00
Member
Copy link
No description provided.
nzinkevich self-assigned this 2024-10-18 10:06:36 +00:00
nzinkevich added 2 commits 2024-10-18 10:06:37 +00:00 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
(cherry picked from commit fcf99d9a59)
[#142] Fix multipart-objects download
Some checks failed
/ DCO (pull_request) Failing after 1m11s
Details
/ Builds (pull_request) Successful in 1m15s
Details
/ Vulncheck (pull_request) Successful in 1m36s
Details
/ Lint (pull_request) Successful in 2m20s
Details
/ Tests (pull_request) Successful in 1m17s
Details
a9065038c5 
Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
(cherry picked from commit 495f745535)
nzinkevich force-pushed support/v0.30_fix_multipart from a9065038c5 to 9c3009b03d 2024-10-18 10:21:17 +00:00 Compare
nzinkevich changed title from support: fix download of multipart objects to Support: fix download of multipart objects 2024-10-18 10:52:12 +00:00
nzinkevich changed title from Support: fix download of multipart objects to [#155] Support: fix download of multipart objects 2024-10-18 10:52:45 +00:00
alexvanin force-pushed support/v0.30_fix_multipart from 9c3009b03d to d7948a9d36 2024-10-18 10:58:01 +00:00 Compare
requested reviews from storage-services-developers, storage-services-committers 2024-10-18 11:14:48 +00:00
dkirillov commented 2024-10-18 11:17:46 +00:00
Member
Copy link

Is it ok that we add de3d2c21bf ?

@alexvanin

Is it ok that we add https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/commit/de3d2c21bf6e005d3a580a6c4b3acbd401a69adb ? @alexvanin
alexvanin commented 2024-10-18 12:41:07 +00:00
Owner
Copy link

Is it ok that we add de3d2c21bf ?

If this small refactor allows much easier cherry-pick, don't see any problem with that.
We also took some code from #141 for tree service.

> Is it ok that we add de3d2c21bf ? If this small refactor allows much easier cherry-pick, don't see any problem with that. We also took some code from https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/pulls/141 for tree service.
alexvanin approved these changes 2024-10-18 12:41:15 +00:00
alexvanin merged commit d7948a9d36 into support/v0.30 2024-10-18 12:50:56 +00:00
alexvanin deleted branch support/v0.30_fix_multipart 2024-10-18 12:50:57 +00:00
alexvanin added this to the v0.30.3 milestone 2024-10-18 12:51:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.30.3
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nzinkevich
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#155
No description provided.
Delete branch "nzinkevich/frostfs-http-gw:support/v0.30_fix_multipart"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?