[#174] Add kludge additional search #180
No reviewers
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-http-gw#180
Loading…
Reference in a new issue
No description provided.
Delete branch "r.loginov/frostfs-http-gw:feature/174-add_kludge_additional_search"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
close #174
Example scenario:
Nitpick:
kludge.additional_search
is a very nondescriptive name. May be we could come up with a better name? I suggestkludge.enable_filepath_fallback
afce681f77
tobadf5e4f09
I like your suggestion. I'll wait a little longer, maybe there will be more suggestions for reinvention of this parameter.
I like
enable_filepath_fallback
.We've decided to move this setting to
feature
config section instead ofkludge
. It may be considered as extra heuristics to process objects withoutFilePath
attribute.badf5e4f09
to6ad3e9dfcc
6ad3e9dfcc
to209a2ee41c
@ -323,0 +343,4 @@
return false
}
return strings.HasPrefix(val, "/") && strings.Count(val, "/") == 1 || !strings.ContainsRune(val, '/')
Why do we use
strings.ContainsRune
rather than juststrings.Contains
?For some reason I thought it would be faster for single characters. However, I looked at the source code, there is almost no difference. And the benchmarks are the same. I'll change it.
LGTM
209a2ee41c
toef2b75597c
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings