TrueCloudLab/frostfs-http-gw
18
1
Fork 17
Code Issues 9 Pull requests 6 Projects Releases 10 Activity Actions

[#185] Update SDK to support new tree/pool version #185

Open
mbiryukova wants to merge 1 commit from mbiryukova/frostfs-http-gw:feature/update_sdk into master
pull from: mbiryukova/frostfs-http-gw:feature/update_sdk
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 15 +299 -38
mbiryukova commented 2024-12-20 08:43:24 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-12-20 08:43:24 +00:00
mbiryukova added 1 commit 2024-12-20 08:43:25 +00:00
[#xxx] Update SDK to support new tree/pool version
Some checks failed
/ DCO (pull_request) Failing after 7m56s
Details
/ Vulncheck (pull_request) Successful in 8m16s
Details
/ Lint (pull_request) Successful in 3m40s
Details
/ Tests (pull_request) Successful in 2m19s
Details
/ Builds (pull_request) Successful in 1m58s
Details
3f13b6fed2 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-developers 2024-12-20 08:43:25 +00:00
mbiryukova requested review from storage-services-committers 2024-12-20 08:43:25 +00:00
mbiryukova force-pushed feature/update_sdk from 3f13b6fed2 to cd53b9c883 2024-12-20 08:44:09 +00:00 Compare
mbiryukova changed title from [#xxx] Update SDK to support new tree/pool version to [#185] Update SDK to support new tree/pool version 2024-12-20 08:44:41 +00:00
mbiryukova force-pushed feature/update_sdk from cd53b9c883 to 4474f052de 2024-12-20 11:12:18 +00:00 Compare
dkirillov approved these changes 2024-12-20 12:08:16 +00:00
Dismissed
dkirillov left a comment
Member
Copy link

LGTM

LGTM
docs/gate-configuration.md Outdated
@ -348,0 +346,4 @@
| Parameter | Type | Default value | Description |
|-----------|-----------------------------------|---------------------------------|-------------------------------------------------------------|
| `buckets` | [Cache config](#cache-subsection) | `lifetime: 60s`<br>`size: 1000` | Cache which contains mapping of bucket name to bucket info. |
| `netmap` | [Cache config](#cache-subsection) | `lifetime: 1m` | Cache which stores netmap. |
dkirillov commented 2024-12-20 12:04:32 +00:00
Member
Copy link

Probably we should mention that netmap.size isn't applied to to this cache

Probably we should mention that `netmap.size` isn't applied to to this cache
internal/cache/netmap.go Outdated
@ -0,0 +25,4 @@
)
const (
DefaultNetmapCacheLifetime = 1 * time.Minute
dkirillov commented 2024-12-20 12:06:17 +00:00
Member
Copy link

nitpick: We can write just

DefaultNetmapCacheLifetime = time.Minute
nitpick: We can write just ```golang DefaultNetmapCacheLifetime = time.Minute ```
mbiryukova force-pushed feature/update_sdk from 4474f052de to bfa9ae7937 2024-12-20 12:26:31 +00:00 Compare
mbiryukova dismissed dkirillov's review 2024-12-20 12:26:34 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

All checks were successful
/ DCO (pull_request) Successful in 1m35s
Required
Details
/ Vulncheck (pull_request) Successful in 7m16s
Required
Details
/ Lint (pull_request) Successful in 8m19s
Required
Details
/ Tests (pull_request) Successful in 2m9s
Required
Details
/ Builds (pull_request) Successful in 2m5s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/update_sdk:mbiryukova-feature/update_sdk
git checkout mbiryukova-feature/update_sdk
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#185
No description provided.
Delete branch "mbiryukova/frostfs-http-gw:feature/update_sdk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?