TrueCloudLab/frostfs-http-gw
17
1
Fork 18
Code Issues 10 Pull requests 4 Projects Releases 16 Activity Actions

[#191] Refactor error handling and logging #221

Open
dkirillov wants to merge 2 commits from dkirillov/frostfs-http-gw:bugfix/191-correct-status-codes into master
pull from: dkirillov/frostfs-http-gw:bugfix/191-correct-status-codes
merge into: TrueCloudLab:master
Conversation 0 Commits 2 Files changed 17 +393 -374
dkirillov commented 2025-03-03 15:08:10 +00:00
Member
Copy link

close #191

close #191
dkirillov self-assigned this 2025-03-03 15:08:10 +00:00
dkirillov added 1 commit 2025-03-03 15:08:10 +00:00
[#191] Refactor error handling and logging
Some checks failed
/ DCO (pull_request) Successful in 36s
Details
/ Builds (pull_request) Successful in 1m3s
Details
/ Vulncheck (pull_request) Successful in 58s
Details
/ OCI image (pull_request) Successful in 1m17s
Details
/ Lint (pull_request) Failing after 1m26s
Details
/ Tests (pull_request) Successful in 1m4s
Details
/ Integration tests (pull_request) Failing after 5m32s
Details
982ae32bc4 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed bugfix/191-correct-status-codes from 982ae32bc4 to 1796dfb6c1 2025-03-03 15:12:24 +00:00 Compare
dkirillov force-pushed bugfix/191-correct-status-codes from 1796dfb6c1 to d4eb7fe86e 2025-03-04 11:22:19 +00:00 Compare
dkirillov force-pushed bugfix/191-correct-status-codes from d4eb7fe86e to 224bc10667 2025-03-04 11:28:31 +00:00 Compare
requested review from storage-services-developers 2025-03-04 11:28:41 +00:00
dkirillov changed title from WIP: [#191] Refactor error handling and logging to [#191] Refactor error handling and logging 2025-03-04 11:28:45 +00:00
requested review from storage-services-committers 2025-03-04 11:28:45 +00:00
nzinkevich reviewed 2025-03-06 12:51:44 +00:00
cmd/http-gw/app.go Outdated
@ -735,3 +735,3 @@
r.RedirectTrailingSlash = true
r.NotFound = func(r *fasthttp.RequestCtx) {
handler.ResponseError(r, "Not found", fasthttp.StatusNotFound)
handler.ResponseError(r, "Router Not found", fasthttp.StatusNotFound)
nzinkevich commented 2025-03-06 12:05:38 +00:00
Member
Copy link

Router -> Route

`Router` -> `Route`
👍 1
dkirillov force-pushed bugfix/191-correct-status-codes from 224bc10667 to 75328dd934 2025-03-10 14:51:17 +00:00 Compare
All checks were successful
/ DCO (pull_request) Successful in 33s
Required
Details
/ Vulncheck (pull_request) Successful in 46s
Required
Details
/ Builds (pull_request) Successful in 1m12s
Required
Details
/ OCI image (pull_request) Successful in 1m23s
Required
Details
/ Lint (pull_request) Successful in 1m54s
Required
Details
/ Tests (pull_request) Successful in 56s
Required
Details
/ Integration tests (pull_request) Successful in 5m46s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u bugfix/191-correct-status-codes:dkirillov-bugfix/191-correct-status-codes
git checkout dkirillov-bugfix/191-correct-status-codes
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-services-developers
TrueCloudLab/storage-services-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#221
No description provided.
Delete branch "dkirillov/frostfs-http-gw:bugfix/191-correct-status-codes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?