TrueCloudLab/frostfs-http-gw
17
1
Fork 18
Code Issues 10 Pull requests 6 Projects Releases 16 Packages 1 Activity Actions

[#226] Improve CORS validation #238

Open
mbiryukova wants to merge 1 commit from mbiryukova/frostfs-http-gw:feature/cors_validation into master
pull from: mbiryukova/frostfs-http-gw:feature/cors_validation
merge into: TrueCloudLab:master
Conversation 3 Commits 1 Files changed 3 +115
mbiryukova commented 2025-04-30 13:09:13 +00:00
Member
Copy link

Closes #226

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #226 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2025-04-30 13:09:13 +00:00
mbiryukova added 1 commit 2025-04-30 13:09:13 +00:00
[#226] Improve CORS validation
All checks were successful
/ DCO (pull_request) Successful in 35s
Details
/ Vulncheck (pull_request) Successful in 1m0s
Details
/ Builds (pull_request) Successful in 1m6s
Details
/ OCI image (pull_request) Successful in 1m23s
Details
/ Lint (pull_request) Successful in 2m26s
Details
/ Tests (pull_request) Successful in 1m10s
Details
/ Integration tests (pull_request) Successful in 5m48s
Details
1f6368471a 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
requested reviews from storage-services-developers, storage-services-committers 2025-04-30 13:09:13 +00:00
nzinkevich reviewed 2025-04-30 13:22:10 +00:00
internal/handler/cors.go Outdated
@ -80,2 +80,4 @@
for _, rule := range corsConfig.CORSRules {
if err = checkCORSRule(rule); err != nil {
log.Error(logs.InvalidCORSRue, zap.Error(err), logs.TagField(logs.TagDatapath))
nzinkevich commented 2025-04-30 13:22:10 +00:00
Member
Copy link

logs.InvalidCorsRule

`logs.InvalidCorsRule`
nzinkevich marked this conversation as resolved
nzinkevich reviewed 2025-04-30 13:24:35 +00:00
internal/handler/cors.go Outdated
@ -178,6 +186,22 @@ func (h *Handler) SetCORSHeaders(req *fasthttp.RequestCtx) {
}
}
func checkCORSRule(rule data.CORSRule) error {
nzinkevich commented 2025-04-30 13:24:35 +00:00
Member
Copy link

What about more meaningful name like checkWildcards or something like that?

What about more meaningful name like `checkWildcards` or something like that?
nzinkevich marked this conversation as resolved
mbiryukova force-pushed feature/cors_validation from 1f6368471a to 871ae5d763 2025-04-30 14:13:55 +00:00 Compare
dkirillov approved these changes 2025-05-07 09:36:38 +00:00
dkirillov left a comment
Member
Copy link

LGTM

LGTM
All checks were successful
/ DCO (pull_request) Successful in 33s
Required
Details
/ Vulncheck (pull_request) Successful in 52s
Required
Details
/ OCI image (pull_request) Successful in 1m14s
Required
Details
/ Lint (pull_request) Successful in 2m25s
Required
Details
/ Tests (pull_request) Successful in 1m8s
Required
Details
/ Integration tests (pull_request) Successful in 5m46s
Required
Details
/ Builds (pull_request) Successful in 43s
Required
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/cors_validation:mbiryukova-feature/cors_validation
git checkout mbiryukova-feature/cors_validation
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#238
No description provided.
Delete branch "mbiryukova/frostfs-http-gw:feature/cors_validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?