TrueCloudLab/frostfs-http-gw
14
1
Fork 16
Code Issues 7 Pull requests 3 Projects Releases 8 Activity Actions

Feature/2 rebranding #3

Merged
KirillovDenis merged 3 commits from feature/2-rebranding into master 2022-12-20 10:34:42 +00:00
Conversation 0 Commits 3 Files changed 26 +129 -127
KirillovDenis commented 2022-12-16 08:55:19 +00:00 (Migrated from github.com)
Copy link

Related to #2

Related to #2
alexvanin (Migrated from github.com) reviewed 2022-12-19 12:54:54 +00:00
alexvanin (Migrated from github.com) left a comment
Copy link
  • Update paths in frostfs-http-gw.dirs, frostfs-http-gw.postinst

Overall LGTM. In next PR let's refactor internal code.

- Update paths in `frostfs-http-gw.dirs`, `frostfs-http-gw.postinst` Overall LGTM. In next PR let's refactor internal code.
README.md
@ -100,3 +99,4 @@
$ frostfs-http-gw -p $NEOFS_NODE -w $WALLET_PATH --address $ACCOUNT_ADDRESS
```
Example:
```
alexvanin (Migrated from github.com) commented 2022-12-19 12:47:36 +00:00
Copy link

I assume we are going to rename it to s0*.frostfs.devenv. Mention that explicitly in #2 or fix it here. There are plenty of dev-env links and usage of $NEOFS_NODE.

I assume we are going to rename it to `s0*.frostfs.devenv`. Mention that explicitly in #2 or fix it here. There are plenty of dev-env links and usage of `$NEOFS_NODE`.
debian/copyright
alexvanin (Migrated from github.com) commented 2022-12-19 12:43:08 +00:00
Copy link
Source: https://github.com/TrueCloudLab/frostfs-http-gw
```suggestion Source: https://github.com/TrueCloudLab/frostfs-http-gw ```
alexvanin (Migrated from github.com) commented 2022-12-19 12:43:41 +00:00
Copy link
           (https://github.com/TrueCloudLab/frostfs-http-gw/blob/master/CREDITS.md)
```suggestion (https://github.com/TrueCloudLab/frostfs-http-gw/blob/master/CREDITS.md) ```
KirillovDenis (Migrated from github.com) reviewed 2022-12-19 13:50:07 +00:00
README.md
@ -100,3 +99,4 @@
$ frostfs-http-gw -p $NEOFS_NODE -w $WALLET_PATH --address $ACCOUNT_ADDRESS
```
Example:
```
KirillovDenis (Migrated from github.com) commented 2022-12-19 13:50:07 +00:00
Copy link

I thought we should wait for renaming in dev-env here

I thought we should wait for renaming in dev-env [here](https://github.com/TrueCloudLab/frostfs-dev-env/blob/1099cdcef885efbbec56bc869dc04a64696ada23/.env#L2)
alexvanin (Migrated from github.com) reviewed 2022-12-19 14:39:59 +00:00
debian/copyright
alexvanin (Migrated from github.com) commented 2022-12-19 14:36:26 +00:00
Copy link

I think it is just 2022. /cc @realloc

I think it is just 2022. /cc @realloc
debian/frostfs-http-gw.postinst
@ -0,0 +17,4 @@
# for details, see https://www.debian.org/doc/debian-policy/ or
# the debian-policy package
alexvanin (Migrated from github.com) commented 2022-12-19 14:38:04 +00:00
Copy link
            chmod -f 0640 /etc/frostfs/$USERNAME/config.yaml || true
```suggestion chmod -f 0640 /etc/frostfs/$USERNAME/config.yaml || true ```
debian/frostfs-http-gw.postrm
@ -0,0 +29,4 @@
*)
echo "postrm called with unknown argument \`$1'" >&2
exit 1
alexvanin (Migrated from github.com) commented 2022-12-19 14:39:14 +00:00
Copy link

debian/frostfs-http-gw.dirs still uses srv/neofs_cache.

`debian/frostfs-http-gw.dirs` still uses `srv/neofs_cache`.
realloc (Migrated from github.com) reviewed 2022-12-20 08:52:05 +00:00
debian/copyright
realloc (Migrated from github.com) commented 2022-12-20 08:52:04 +00:00
Copy link

FrostFS development by TrueCloudLab started at 2022, so we need to add a line, not t replace NSPCC.

FrostFS development by TrueCloudLab started at 2022, so we need to add a line, not t replace NSPCC.
alexvanin (Migrated from github.com) approved these changes 2022-12-20 10:34:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#3
No description provided.
Delete branch "feature/2-rebranding"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?