TrueCloudLab/frostfs-http-gw
17
1
Fork 18
Code Issues 9 Pull requests 1 Projects Releases 16 Activity Actions

[#76] Add go1.21 to CI #76

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-http-gw:feature/add_go1.21_to_ci into master 2023-08-31 11:49:48 +00:00
Conversation 0 Commits 1 Files changed 7 +7 -7
7 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.forgejo/workflows/builds.yml
View file

@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
strategy: strategy:
matrix: matrix:
go_versions: [ '1.19', '1.20' ] go_versions: [ '1.20', '1.21' ]
fyrchik commented 2023-08-28 11:50:53 +00:00
Outdated
Review
Copy link

Shouldn't we remove 1.19 too?
We agreed to support the last 2 versions.

Shouldn't we remove 1.19 too? We agreed to support the last 2 versions.
👍 1
dkirillov commented 2023-08-28 11:53:43 +00:00
Outdated
Review
Copy link

Probably we also should bump go version in go.mod

Probably we also should bump go version in [go.mod](https://git.frostfs.info/TrueCloudLab/frostfs-http-gw/src/commit/cc69601b32a09290dae3ccdeab4eb39515251172/go.mod#L3)
alexvanin commented 2023-08-28 12:56:29 +00:00
Outdated
Review
Copy link

We should and we will.

We should and we will.
fail-fast: false fail-fast: false
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3

2
.forgejo/workflows/dco.yml
View file

@ -12,7 +12,7 @@ jobs:
- name: Setup Go - name: Setup Go
uses: actions/setup-go@v3 uses: actions/setup-go@v3
with: with:
go-version: '1.20' go-version: '1.21'
- name: Run commit format checker - name: Run commit format checker
uses: https://git.frostfs.info/TrueCloudLab/dco-go@v1 uses: https://git.frostfs.info/TrueCloudLab/dco-go@v1

2
.forgejo/workflows/tests.yml
View file

@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
strategy: strategy:
matrix: matrix:
go_versions: [ '1.19', '1.20' ] go_versions: [ '1.20', '1.21' ]
fail-fast: false fail-fast: false
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3

2
.forgejo/workflows/vulncheck.yml
View file

@ -12,7 +12,7 @@ jobs:
- name: Setup Go - name: Setup Go
uses: actions/setup-go@v3 uses: actions/setup-go@v3
with: with:
go-version: '1.20' go-version: '1.21'
- name: Install govulncheck - name: Install govulncheck
run: go install golang.org/x/vuln/cmd/govulncheck@latest run: go install golang.org/x/vuln/cmd/govulncheck@latest

2
Dockerfile
View file

@ -1,4 +1,4 @@
FROM golang:1.19-alpine as basebuilder FROM golang:1.21-alpine as basebuilder
alexvanin commented 2023-08-31 11:23:51 +00:00
Outdated
Review
Copy link

Let's use latest go version for all our builds. For instance, storage node uses go1.21 for builds https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/.docker/Dockerfile.storage

Let's use latest go version for all our builds. For instance, storage node uses go1.21 for builds https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/.docker/Dockerfile.storage
RUN apk add --update make bash ca-certificates RUN apk add --update make bash ca-certificates
FROM basebuilder as builder FROM basebuilder as builder

2
Makefile
View file

@ -2,7 +2,7 @@
REPO ?= $(shell go list -m) REPO ?= $(shell go list -m)
VERSION ?= $(shell git describe --tags --match "v*" --dirty --always --abbrev=8 2>/dev/null || cat VERSION 2>/dev/null || echo "develop") VERSION ?= $(shell git describe --tags --match "v*" --dirty --always --abbrev=8 2>/dev/null || cat VERSION 2>/dev/null || echo "develop")
GO_VERSION ?= 1.19 GO_VERSION ?= 1.20
LINT_VERSION ?= 1.49.0 LINT_VERSION ?= 1.49.0
BUILD ?= $(shell date -u --iso=seconds) BUILD ?= $(shell date -u --iso=seconds)

2
go.mod
View file

@ -1,6 +1,6 @@
module git.frostfs.info/TrueCloudLab/frostfs-http-gw module git.frostfs.info/TrueCloudLab/frostfs-http-gw
go 1.19 go 1.20
require ( require (
git.frostfs.info/TrueCloudLab/frostfs-api-go/v2 v2.15.1-0.20230802075510-964c3edb3f44 git.frostfs.info/TrueCloudLab/frostfs-api-go/v2 v2.15.1-0.20230802075510-964c3edb3f44