[#74] Replace atomics with mutex for reloadable params #84

mbiryukova · 2023-09-08T09:43:53Z

mbiryukova commented

2023-09-08 09:43:53 +00:00

Closes #74

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #74 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova self-assigned this 2023-09-08 09:43:53 +00:00

mbiryukova requested review from storage-services-committers 2023-09-08 09:59:49 +00:00

mbiryukova requested review from storage-services-developers 2023-09-08 09:59:50 +00:00

pogpp approved these changes 2023-09-11 09:57:18 +00:00

r.loginov approved these changes 2023-09-13 12:01:17 +00:00

dkirillov reviewed 2023-09-20 13:32:32 +00:00

internal/handler/settings.go Outdated

													
				@ -0,0 +3,4 @@

				import "sync"

				// Settings stores reloading parameters, so it has to provide getters and setters which use RWMutex.

				type Settings struct {

dkirillov commented

2023-09-20 13:32:32 +00:00

I'm not sure that implementation of Config interface should be in the same package. I would suggest move this to cmd/http-gw the same as for s3-gw in TrueCloudLab/frostfs-s3-gw#206

I'm not sure that implementation of `Config` interface should be in the same package. I would suggest move this to `cmd/http-gw` the same as for s3-gw in https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/206

dkirillov marked this conversation as resolved

mbiryukova force-pushed feature/replace_atomics_with_mutex from 30e4f1cb68 to b8e06d7dbb

2023-09-21 09:05:48 +00:00

Compare

dkirillov reviewed 2023-09-21 12:09:55 +00:00

internal/handler/handler.go Outdated

													
				@ -23,1 +22,4 @@

				type Config interface {

					DefaultTimestamp() bool

					SetDefaultTimestamp(val bool)

dkirillov commented

2023-09-21 12:09:55 +00:00

Why do we need setters now?

mbiryukova commented

2023-09-21 14:00:00 +00:00

Poster

Removed

dkirillov marked this conversation as resolved

mbiryukova force-pushed feature/replace_atomics_with_mutex from b8e06d7dbb to e26577e753

2023-09-21 13:28:24 +00:00

Compare

dkirillov approved these changes 2023-09-21 14:05:44 +00:00

alexvanin approved these changes 2023-10-04 10:50:12 +00:00

alexvanin merged commit e26577e753 into master

2023-10-04 10:50:20 +00:00

alexvanin deleted branch feature/replace_atomics_with_mutex

2023-10-04 10:50:24 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-http-gw#84