TrueCloudLab/frostfs-locode-db
15
0
Fork 9
Code Issues 5 Pull requests 1 Releases 1 Activity

[#6] Add automated database updater #10

Merged
realloc merged 1 commit from george.bartolomey/issue6pr into master 2024-07-05 07:35:00 +00:00 AGit
Conversation 0 Commits 1 Files changed 2 +21 -1
george.bartolomey commented 2024-07-03 14:15:14 +00:00
Member
Copy link
No description provided.
requested review from realloc 2024-07-03 14:25:45 +00:00
requested review from fyrchik 2024-07-04 07:00:02 +00:00
fyrchik reviewed 2024-07-04 07:21:48 +00:00
.forgejo/workflows/updatechecker.yml
@ -0,0 +13,4 @@
git switch -c update-dbs
git add .
git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@git.frostfs.info/TrueCloudLab/frostfs-locode-db
git commit -m "Update databases" && \
fyrchik commented 2024-07-04 07:21:43 +00:00
Owner
Copy link

How about mentioning having some version info in the commit message?

How about mentioning having some version info in the commit message?
george.bartolomey commented 2024-07-04 08:38:17 +00:00
Author
Member
Copy link

What you do mean by "version"? Date of update or log of changed files?

What you do mean by "version"? Date of update or log of changed files?
fyrchik commented 2024-07-04 10:59:41 +00:00
Owner
Copy link

I mean we have 27 December 2023 UN/LOCODE by Country version 2023-2 at the https://unece.org/trade/cefact/UNLOCODE-Download , either date or 2023-2 could serve as a version.

Or 232 in the loc232... filename, it seems related.

Not very important, if it is hard to extract, but IMO is useful.

I mean we have `27 December 2023 UN/LOCODE by Country version 2023-2` at the https://unece.org/trade/cefact/UNLOCODE-Download , either date or `2023-2` could serve as a version. Or `232` in the `loc232...` filename, it seems related. Not very important, if it is hard to extract, but IMO is useful.
george.bartolomey commented 2024-07-04 11:11:27 +00:00
Author
Member
Copy link

I can introduce this by writing loc232 to tmp/version.txt. Also we have OpenFlights which doesn't have any releases. Is there any method to get version of OpenFlights databases?

I can introduce this by writing `loc232` to `tmp/version.txt`. Also we have OpenFlights which doesn't have any releases. Is there any method to get version of OpenFlights databases?
george.bartolomey commented 2024-07-04 11:35:23 +00:00
Author
Member
Copy link

Done.

Done.
fyrchik marked this conversation as resolved
.forgejo/workflows/updatechecker.yml
@ -0,0 +14,4 @@
git add .
git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@git.frostfs.info/TrueCloudLab/frostfs-locode-db
git commit -m "Update databases" && \
git push origin HEAD:refs/for/master -o title="Automatic update databases" -o topic=update-db
fyrchik commented 2024-07-04 07:20:52 +00:00
Owner
Copy link

Should be either Automatically update databases or Automatic database update

Should be either `Automatically update databases` or `Automatic database update`
fyrchik commented 2024-07-04 13:20:06 +00:00
Owner
Copy link

@george.bartolomey please, change this too

@george.bartolomey please, change this too
george.bartolomey commented 2024-07-04 14:51:37 +00:00
Author
Member
Copy link

I changed this already.

I changed this already.
fyrchik commented 2024-07-04 15:05:50 +00:00
Owner
Copy link

Oh, right, sorry. Forgejo usually prints outdated if the code in line has changed.

Oh, right, sorry. Forgejo usually prints `outdated` if the code in line has changed.
fyrchik marked this conversation as resolved
george.bartolomey force-pushed george.bartolomey/issue6pr from 8511bfa18a to fa89d45027 2024-07-04 09:46:32 +00:00 Compare
george.bartolomey force-pushed george.bartolomey/issue6pr from fa89d45027 to 3feec01b21 2024-07-04 11:34:47 +00:00 Compare
fyrchik approved these changes 2024-07-04 13:19:49 +00:00
realloc approved these changes 2024-07-05 07:34:43 +00:00
realloc merged commit 3feec01b21 into master 2024-07-05 07:35:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
realloc
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-locode-db#10
No description provided.
Delete branch "george.bartolomey/issue6pr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?