[#7] Add local tool for building database file #11

Merged
realloc merged 1 commit from george.bartolomey/frostfs-locode-db:feature-local-util into master 2024-09-04 19:50:57 +00:00

Added frostfs-locode-db utility that can generate and view database
file. Interdependency between frostfs-node and frostfs-locode-db
eliminated. Now it is possible to generate database file by just typing
the make command. Go package
git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode copied to this
repository.

Signed-off-by: George Bartolomey george@bh4.ru

Closes: #7

Added frostfs-locode-db utility that can generate and view database file. Interdependency between frostfs-node and frostfs-locode-db eliminated. Now it is possible to generate database file by just typing the make command. Go package git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode copied to this repository. Signed-off-by: George Bartolomey <george@bh4.ru> Closes: #7
george.bartolomey requested review from realloc 2024-07-08 08:03:40 +00:00
george.bartolomey requested review from fyrchik 2024-07-08 08:03:41 +00:00
Owner

Please break it into several commits.

Please break it into several commits.
george.bartolomey force-pushed feature-local-util from 40e1ea859b to 998cc3786f 2024-07-08 08:42:54 +00:00 Compare
Author
Member

Please break it into several commits.

Done.

> Please break it into several commits. Done.
dstepanov-yadro reviewed 2024-07-08 14:03:32 +00:00
CONTRIBUTING.md Outdated
@ -0,0 +23,4 @@
## Development Workflow
Start by forking the `frostfs-node` repository, make changes in a branch and then

Need to fix repository name.

Need to fix repository name.
Author
Member

Fixed.

Fixed.
acid-ant reviewed 2024-07-08 14:18:31 +00:00
CONTRIBUTING.md Outdated
@ -0,0 +3,4 @@
First, thank you for contributing! We love and encourage pull requests from
everyone. Please follow the guidelines:
- Check the open [issues](https://git.frostfs.info/TrueCloudLab/frostfs-node/issues) and
Member

frostfs-node -> frostfs-locode-db
Need to do the same changes for the pull requests too.

frostfs-node -> frostfs-locode-db Need to do the same changes for the `pull requests` too.
Author
Member

I fixed that.

I fixed that.
acid-ant marked this conversation as resolved
acid-ant reviewed 2024-07-08 14:22:52 +00:00
README.md Outdated
@ -43,11 +43,11 @@ $ make
Then run frost-cli command to generate boltDB file.
Member

frost-cli -> frostfs-locode-db
boltDB file -> UN/LOCODE database

`frost-cli` -> `frostfs-locode-db` `boltDB file` -> `UN/LOCODE database`
Author
Member

Updated.

Updated.
acid-ant marked this conversation as resolved
acid-ant reviewed 2024-07-08 14:24:49 +00:00
README.md Outdated
@ -71,7 +71,7 @@ $ ./frostfs-cli util locode generate \
You can test generated database with `frostfs-cli`.
Member

frostfs-cli -> frostfs-locode-db

`frostfs-cli` -> `frostfs-locode-db`
Author
Member

Done.

Done.
acid-ant marked this conversation as resolved
george.bartolomey force-pushed feature-local-util from 998cc3786f to b240cb937a 2024-07-08 14:44:27 +00:00 Compare
acid-ant reviewed 2024-07-09 09:05:01 +00:00
go.mod Outdated
@ -0,0 +1,21 @@
module git.frostfs.info/TrueCloudLab/frostfs-locode-db
go 1.22.4
Member

Let's use the same version as in frostfs-node repo.

Let's use the same version as in `frostfs-node` repo.
Author
Member

Thank you, I fixed it.

Thank you, I fixed it.
Author
Member

Oh, in README.md i found the requirement of Go 1.22.4.

Oh, in README.md i found the requirement of Go 1.22.4.
george.bartolomey marked this conversation as resolved
Member

Could you be so kind to reflect in the commit message that this code moved from frostfs-node.

Could you be so kind to reflect in the commit message that this code moved from `frostfs-node`.
Author
Member

Could you be so kind to reflect in the commit message that this code moved from frostfs-node.

[#7] Add local tool for building database file

Added frostfs-locode-db CLI utility that can generate and view UN/LOCODE
database files. Go package
git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode copied to
this repository to eliminate interdependency between frostfs-node and
frostfs-locode-db projects. The process of building database files
reduced to starting make command.

Signed-off-by: George Bartolomey george@bh4.ru

> Could you be so kind to reflect in the commit message that this code moved from `frostfs-node`. > [#7] Add local tool for building database file > Added frostfs-locode-db CLI utility that can generate and view UN/LOCODE > database files. Go package > git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode copied to > this repository to eliminate interdependency between frostfs-node and > frostfs-locode-db projects. The process of building database files > reduced to starting make command. > > Signed-off-by: George Bartolomey <george@bh4.ru>
george.bartolomey force-pushed feature-local-util from b240cb937a to 066cfc3e8b 2024-07-09 15:55:17 +00:00 Compare
acid-ant approved these changes 2024-07-10 06:44:55 +00:00
george.bartolomey force-pushed feature-local-util from 066cfc3e8b to 9e53f4d88c 2024-07-10 07:38:43 +00:00 Compare
george.bartolomey requested review from acid-ant 2024-07-10 07:39:52 +00:00
george.bartolomey force-pushed feature-local-util from 9e53f4d88c to 65761deb5c 2024-07-10 07:50:21 +00:00 Compare
acid-ant approved these changes 2024-07-10 07:54:24 +00:00
aarifullin approved these changes 2024-07-10 09:42:32 +00:00
realloc merged commit 65761deb5c into master 2024-07-16 10:09:10 +00:00
realloc deleted branch feature-local-util 2024-07-16 10:09:18 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-locode-db#11
No description provided.