Fix broken build with parallel make #4

Merged

realloc merged 1 commit from realloc/frostfs-locode-db:fix/makedep into master

2023-04-21 09:30:43 +00:00

realloc commented

2023-04-21 09:20:36 +00:00

Owner

Adding $(DIRS) dependency to fix parallel make build.

Previously, targets in/airports.dat, in/countries.dat and unlocode did not have a dependency on DIRS.
The build could fail if parallel make is used and tmp directory hasn't been created yet.

NOTE: make -j 24 all
⇒ Ensure dir: in
wget -c https://service.unece.org/trade/locode/loc222csv.zip -O tmp/loc222csv.zip
⇒ Ensure dir: tmp
tmp/loc222csv.zip: No such file or directory
make: *** [Makefile:34: unlocode] Error 1

Adding $(DIRS) dependency to fix parallel make build. Previously, targets `in/airports.dat`, `in/countries.dat` and `unlocode` did not have a dependency on DIRS. The build could fail if parallel make is used and tmp directory hasn't been created yet. ``` NOTE: make -j 24 all ⇒ Ensure dir: in wget -c https://service.unece.org/trade/locode/loc222csv.zip -O tmp/loc222csv.zip ⇒ Ensure dir: tmp tmp/loc222csv.zip: No such file or directory make: *** [Makefile:34: unlocode] Error 1 ```

realloc self-assigned this 2023-04-21 09:20:36 +00:00

realloc added 1 commit 2023-04-21 09:20:37 +00:00

[#4 ] Fix broken build with parallel make a022bf2e40

Adding $(DIRS) dependency to fix parallel make build.

Without this dependency targets downloading external databases may fail
if output directory was not created yet.

Signed-off-by: Stanislav Bogatyrev <s.bogatyrev@yadro.com>

realloc requested review from storage-core-developers 2023-04-21 09:20:52 +00:00

realloc requested review from storage-core-committers 2023-04-21 09:20:52 +00:00