TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 106 Pull requests 12 Projects Releases 2 Activity Actions

[#1540] getSvc: Do not log context canceled errors during EC assemble
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 3m4s
Details
DCO action / DCO (pull_request) Successful in 3m39s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m38s
Details
Tests and linters / gopls check (pull_request) Successful in 3m53s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m24s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m41s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m23s
Details
Build / Build Components (pull_request) Successful in 5m47s
Details
Tests and linters / Tests (pull_request) Successful in 9m24s
Details
Tests and linters / Lint (pull_request) Failing after 11m46s
Details

Browse source 
Those errors are fired when it is enough chunks retrieved and error group
cancels other requests.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2024-12-05 10:19:30 +03:00
parent 2d5d4093be
commit 5cd6941276
Signed by: dstepanov-yadro
GPG key ID: 237AF1A763293BC0
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkg/services/object/get/assemblerec.go
View file

@ -238,15 +238,13 @@ func (a *assemblerec) tryGetChunkFromLocalStorage(ctx context.Context, ch object
var object *objectSDK.Object
if a.head {
object, err = a.localStorage.Head(ctx, addr, false)
if err != nil {
if err != nil && !errors.Is(err, context.Canceled) {
a.log.Warn(ctx, logs.GetUnableToHeadPartECObject, zap.String("node", "local"), zap.Stringer("part_id", objID), zap.Error(err))
return nil
}
} else {
object, err = a.localStorage.Get(ctx, addr)
if err != nil {
if err != nil && !errors.Is(err, context.Canceled) {
a.log.Warn(ctx, logs.GetUnableToGetPartECObject, zap.String("node", "local"), zap.Stringer("part_id", objID), zap.Error(err))
return nil
}
}
return object
@ -286,15 +284,13 @@ func (a *assemblerec) tryGetChunkFromRemoteStorage(ctx context.Context, node cli
var object *objectSDK.Object
if a.head {
object, err = a.remoteStorage.headObjectFromNode(ctx, addr, node, false)
if err != nil {
if err != nil && !errors.Is(err, context.Canceled) {
a.log.Warn(ctx, logs.GetUnableToHeadPartECObject, zap.String("node", hex.EncodeToString(node.PublicKey())), zap.Stringer("part_id", objID), zap.Error(err))
return nil
}
} else {
object, err = a.remoteStorage.getObjectFromNode(ctx, addr, node)
if err != nil {
if err != nil && !errors.Is(err, context.Canceled) {
a.log.Warn(ctx, logs.GetUnableToGetPartECObject, zap.String("node", hex.EncodeToString(node.PublicKey())), zap.Stringer("part_id", objID), zap.Error(err))
return nil
}
}
return object