TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 3 Projects Releases 1 Activity Actions

Do not log context canceled errors during EC assemble #1540

Merged
fyrchik merged 2 commits from dstepanov-yadro/frostfs-node:fix/do_not_log_ec_assemble_context_canceled into master 2024-12-05 12:39:50 +00:00
Conversation 0 Commits 2 Files changed 1 +4 -8
dstepanov-yadro commented 2024-12-05 07:25:59 +00:00
Member
Copy link

Those errors are fired when it is enough chunks retrieved and error group
cancels other requests.

Those errors are fired when it is enough chunks retrieved and error group cancels other requests.
dstepanov-yadro added 1 commit 2024-12-05 07:26:00 +00:00
[#9999] getSvc: Do not log context canceled errors during EC assemble
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 2m39s
Details
DCO action / DCO (pull_request) Successful in 3m33s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m55s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m10s
Details
Tests and linters / gopls check (pull_request) Successful in 4m10s
Details
Tests and linters / Tests (pull_request) Successful in 4m51s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m2s
Details
Build / Build Components (pull_request) Successful in 5m15s
Details
Tests and linters / Lint (pull_request) Successful in 5m31s
Details
Tests and linters / Tests with -race (pull_request) Successful in 7m1s
Details
48a8cf9c31 
Those errors are fired when it is enough chunks retrieved and error group
cancels other requests.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/do_not_log_ec_assemble_context_canceled from 48a8cf9c31 to 0c1a366ad5 2024-12-05 07:28:13 +00:00 Compare
dstepanov-yadro force-pushed fix/do_not_log_ec_assemble_context_canceled from 0c1a366ad5 to 5cd6941276 2024-12-05 07:31:19 +00:00 Compare
dstepanov-yadro force-pushed fix/do_not_log_ec_assemble_context_canceled from 5cd6941276 to 339e47e51c 2024-12-05 07:33:06 +00:00 Compare
fyrchik approved these changes 2024-12-05 07:38:24 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-12-05 07:53:02 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-12-05 07:53:03 +00:00
acid-ant approved these changes 2024-12-05 11:33:34 +00:00
fyrchik merged commit 7df3520d48 into master 2024-12-05 12:39:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1540
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/do_not_log_ec_assemble_context_canceled"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?