TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 107 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1329] cli: Skip linking objects in complex object processing
All checks were successful
DCO action / DCO (pull_request) Successful in 2m41s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m42s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 3m50s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m55s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 4m8s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 4m11s
Details
Build / Build Components (1.22) (pull_request) Successful in 4m32s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m20s
Details
Build / Build Components (1.23) (pull_request) Successful in 4m33s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m9s
Details
Tests and linters / Lint (pull_request) Successful in 5m34s
Details
Tests and linters / gopls check (pull_request) Successful in 5m24s
Details

Browse source 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2024-08-23 13:36:52 +03:00
parent bd24beecf8
commit a059a7dcf0
2 changed files with 39 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cmd/frostfs-cli/modules/object/util.go
View file

@ -374,7 +374,7 @@ func collectObjectRelatives(cmd *cobra.Command, cli *client.Client, cnr cid.ID,
common.PrintVerbose(cmd, "Split information received - object is virtual.")
splitInfo := errSplit.SplitInfo()
if members, ok := tryGetSplitMembersByLinkingObject(cmd, splitInfo, prmHead, cnr, true); ok {
if members, ok := tryGetSplitMembersByLinkingObject(cmd, splitInfo, prmHead, cnr); ok {
return members
}
@ -390,7 +390,7 @@ func collectObjectRelatives(cmd *cobra.Command, cli *client.Client, cnr cid.ID,
return nil
}
func tryGetSplitMembersByLinkingObject(cmd *cobra.Command, splitInfo *objectSDK.SplitInfo, prmHead internal.HeadObjectPrm, cnr cid.ID, withLinking bool) ([]oid.ID, bool) {
func tryGetSplitMembersByLinkingObject(cmd *cobra.Command, splitInfo *objectSDK.SplitInfo, prmHead internal.HeadObjectPrm, cnr cid.ID) ([]oid.ID, bool) {
// collect split chain by the descending ease of operations (ease is evaluated heuristically).
// If any approach fails, we don't try the next since we assume that it will fail too.
@ -411,10 +411,7 @@ func tryGetSplitMembersByLinkingObject(cmd *cobra.Command, splitInfo *objectSDK.
common.PrintVerbose(cmd, "Received split members from the linking object: %v", children)
if withLinking {
return append(children, idLinking), true
}
return children, true
return append(children, idLinking), true
}
// linking object is not required for