TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

Fix linking object handling for EC #1329

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/object_nodes_linking into master 2024-09-04 19:51:11 +00:00
Conversation 0 Commits 1 Files changed 2 +39 -44
dstepanov-yadro commented 2024-08-23 10:48:25 +00:00
Member
Copy link

  • For linking, lock and tombstone objects put operation now saves at least parity + 1 from select N copies but not only parity + 1 copies

  • Drop object nodes optimization with flatten complex object data objects only by first member as this member can be linking object

- For linking, lock and tombstone objects put operation now saves at least `parity + 1` from `select N` copies but not only `parity + 1` copies - Drop `object nodes` optimization with flatten complex object data objects only by first member as this member can be linking object
dstepanov-yadro added 2 commits 2024-08-23 10:48:31 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] cli: Skip linking objects in complex object processing
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 1m42s
Details
DCO action / DCO (pull_request) Successful in 1m54s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m32s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 2m41s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 3m0s
Details
Build / Build Components (1.22) (pull_request) Successful in 3m2s
Details
Build / Build Components (1.23) (pull_request) Successful in 3m4s
Details
Tests and linters / Lint (pull_request) Successful in 3m26s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m4s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m28s
Details
Tests and linters / gopls check (pull_request) Successful in 4m38s
Details
333a37703f 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/object_nodes_linking from 333a37703f to a059a7dcf0 2024-08-23 10:51:45 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-08-23 11:09:37 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-08-23 11:09:37 +00:00
fyrchik approved these changes 2024-08-23 12:50:48 +00:00
fyrchik reviewed 2024-08-23 12:52:15 +00:00
cmd/frostfs-cli/modules/object/nodes.go
@ -173,3 +173,3 @@
splitInfo := errSplitInfo.SplitInfo()
if members, ok := tryGetSplitMembersByLinkingObject(cmd, splitInfo, prmHead, cnrID, false); ok {
if members, ok := tryGetSplitMembersByLinkingObject(cmd, splitInfo, prmHead, cnrID); ok {
fyrchik commented 2024-08-23 12:52:15 +00:00
Owner
Copy link

Now we always get linking object here.
Why this doesn't affect the result?

Now we always get linking object here. Why this doesn't affect the result?
dstepanov-yadro commented 2024-08-23 14:26:03 +00:00
Author
Member
Copy link
			if len(obj.Header().Children()) > 0 {
				// linking object is not data object, so skip it
				return nil
			}
``` if len(obj.Header().Children()) > 0 { // linking object is not data object, so skip it return nil } ```
aarifullin approved these changes 2024-08-23 13:02:00 +00:00
fyrchik merged commit a059a7dcf0 into master 2024-08-23 15:42:28 +00:00
fyrchik added this to the v0.43.0 milestone 2024-08-27 07:23:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.43.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1329
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/object_nodes_linking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?