Fix linking object handling for EC #1329

dstepanov-yadro · 2024-08-23T10:48:25Z

dstepanov-yadro commented

2024-08-23 10:48:25 +00:00

For linking, lock and tombstone objects put operation now saves at least parity + 1 from select N copies but not only parity + 1 copies
Drop object nodes optimization with flatten complex object data objects only by first member as this member can be linking object

- For linking, lock and tombstone objects put operation now saves at least `parity + 1` from `select N` copies but not only `parity + 1` copies - Drop `object nodes` optimization with flatten complex object data objects only by first member as this member can be linking object

dstepanov-yadro force-pushed fix/object_nodes_linking from 333a37703f to a059a7dcf0

2024-08-23 10:51:45 +00:00

Compare

dstepanov-yadro requested review from storage-core-committers 2024-08-23 11:09:37 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-08-23 11:09:37 +00:00

fyrchik approved these changes 2024-08-23 12:50:48 +00:00

fyrchik reviewed 2024-08-23 12:52:15 +00:00

cmd/frostfs-cli/modules/object/nodes.go

					
				@ -173,3 +173,3 @@

					splitInfo := errSplitInfo.SplitInfo()

					if members, ok := tryGetSplitMembersByLinkingObject(cmd, splitInfo, prmHead, cnrID, false); ok {

					if members, ok := tryGetSplitMembersByLinkingObject(cmd, splitInfo, prmHead, cnrID); ok {

fyrchik commented

2024-08-23 12:52:15 +00:00

Now we always get linking object here.
Why this doesn't affect the result?

Now we always get linking object here. Why this doesn't affect the result?

dstepanov-yadro commented

2024-08-23 14:26:03 +00:00

			if len(obj.Header().Children()) > 0 {
				// linking object is not data object, so skip it
				return nil
			}

``` if len(obj.Header().Children()) > 0 { // linking object is not data object, so skip it return nil } ```

aarifullin approved these changes 2024-08-23 13:02:00 +00:00

fyrchik merged commit a059a7dcf0 into master

2024-08-23 15:42:28 +00:00

fyrchik referenced this pull request from a commit

2024-08-23 15:42:29 +00:00

[#1329] putSvc: Reset SuccessAfter for non-EC objects in EC container broadcasting

fyrchik referenced this pull request from a commit

2024-08-23 15:42:29 +00:00

[#1329] cli: Skip linking objects in complex object processing

fyrchik added this to the v0.43.0 milestone 2024-08-27 07:23:50 +00:00

dstepanov-yadro referenced this pull request

2024-09-05 13:17:07 +00:00

putSvc: Reset SuccessAfter for non-EC objects in EC container broadcasting, support/v0.42 #1353

fyrchik referenced this pull request from a commit

2024-09-05 13:30:06 +00:00

[#1329] putSvc: Reset SuccessAfter for non-EC objects in EC container broadcasting

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1329