TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 13 Projects Releases 2 Activity Actions

[#1646] cli: Use Cmp() functions for ID-like structs
All checks were successful
DCO action / DCO (pull_request) Successful in 37s
Details
Vulncheck / Vulncheck (pull_request) Successful in 52s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m23s
Details
Build / Build Components (pull_request) Successful in 1m30s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m10s
Details
Tests and linters / Lint (pull_request) Successful in 2m26s
Details
Tests and linters / Tests (pull_request) Successful in 2m32s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m42s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m49s
Details
Tests and linters / gopls check (pull_request) Successful in 3m47s
Details

Browse source 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
This commit is contained in:
Alexander Chuprov 2025-02-20 12:27:07 +03:00
parent 02f3a7f65c
commit b2adf1109e
Signed by: achuprov
GPG key ID: 2D916FFD803B0EDD
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cmd/frostfs-cli/internal/client/client.go
View file

@ -9,7 +9,6 @@ import (
"io" "io"
"os" "os"
"slices" "slices"
"strings"
"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/accounting" "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/accounting"
"git.frostfs.info/TrueCloudLab/frostfs-sdk-go/checksum" "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/checksum"
@ -77,9 +76,7 @@ func ListContainers(ctx context.Context, prm ListContainersPrm) (res ListContain
// SortedIDList returns sorted list of identifiers of user's containers. // SortedIDList returns sorted list of identifiers of user's containers.
func (x ListContainersRes) SortedIDList() []cid.ID { func (x ListContainersRes) SortedIDList() []cid.ID {
list := x.cliRes.Containers() list := x.cliRes.Containers()
slices.SortFunc(list, func(lhs, rhs cid.ID) int { slices.SortFunc(list, cid.ID.Cmp)
return strings.Compare(lhs.EncodeToString(), rhs.EncodeToString())
})
return list return list
} }
@ -687,9 +684,7 @@ func SearchObjects(ctx context.Context, prm SearchObjectsPrm) (*SearchObjectsRes
return nil, fmt.Errorf("read object list: %w", err) return nil, fmt.Errorf("read object list: %w", err)
} }
slices.SortFunc(list, func(a, b oid.ID) int { slices.SortFunc(list, oid.ID.Cmp)
return strings.Compare(a.EncodeToString(), b.EncodeToString())
})
return &SearchObjectsRes{ return &SearchObjectsRes{
ids: list, ids: list,