TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 13 Projects Releases 2 Activity Actions

cli: Use Cmp() functions for ID-like structs #1646

Open
achuprov wants to merge 1 commit from achuprov/frostfs-node:feat/use_cmp into master
pull from: achuprov/frostfs-node:feat/use_cmp
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +2 -7
achuprov commented 2025-02-13 16:44:17 +00:00
Member
Copy link

Ref TrueCloudLab/frostfs-sdk-go#333
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Ref https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/333 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2025-02-13 16:44:18 +00:00
[#1646] cli: Use Cmp() functions for ID-like structs
Some checks failed
DCO action / DCO (pull_request) Successful in 36s
Details
Vulncheck / Vulncheck (pull_request) Failing after 53s
Details
Tests and linters / Tests (pull_request) Failing after 59s
Details
Build / Build Components (pull_request) Failing after 1m5s
Details
Tests and linters / Lint (pull_request) Failing after 1m9s
Details
Tests and linters / Run gofumpt (pull_request) Failing after 1m7s
Details
Tests and linters / Staticcheck (pull_request) Failing after 1m14s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m24s
Details
Tests and linters / Tests with -race (pull_request) Failing after 2m58s
Details
Tests and linters / gopls check (pull_request) Failing after 2m59s
Details
a73fb5c462 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov force-pushed feat/use_cmp from a73fb5c462 to 02f3a7f65c 2025-02-20 09:22:17 +00:00 Compare
achuprov added 1 commit 2025-02-20 09:27:48 +00:00
[#1646] cli: Use Cmp() functions for ID-like structs
All checks were successful
DCO action / DCO (pull_request) Successful in 37s
Details
Vulncheck / Vulncheck (pull_request) Successful in 52s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m23s
Details
Build / Build Components (pull_request) Successful in 1m30s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m10s
Details
Tests and linters / Lint (pull_request) Successful in 2m26s
Details
Tests and linters / Tests (pull_request) Successful in 2m32s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m42s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m49s
Details
Tests and linters / gopls check (pull_request) Successful in 3m47s
Details
b2adf1109e 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov changed title from WIP: cli: Use Cmp() functions for ID-like structs to cli: Use Cmp() functions for ID-like structs 2025-02-20 09:30:42 +00:00
requested reviews from storage-core-committers, storage-core-developers 2025-02-20 09:30:43 +00:00
a-savchuk approved these changes 2025-02-20 09:47:13 +00:00
dstepanov-yadro approved these changes 2025-02-21 06:51:12 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 37s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 52s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m23s
Required
Details
Build / Build Components (pull_request) Successful in 1m30s
Required
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m10s
Required
Details
Tests and linters / Lint (pull_request) Successful in 2m26s
Required
Details
Tests and linters / Tests (pull_request) Successful in 2m32s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m42s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m49s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 3m47s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feat/use_cmp:achuprov-feat/use_cmp
git checkout achuprov-feat/use_cmp
Sign in to join this conversation.
Reviewers
No reviewers
a-savchuk
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1646
No description provided.
Delete branch "achuprov/frostfs-node:feat/use_cmp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?