TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 107 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1367] fstree: Add size hint for Delete
All checks were successful
DCO action / DCO (pull_request) Successful in 1m2s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m20s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m44s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m6s
Details
Build / Build Components (pull_request) Successful in 2m19s
Details
Tests and linters / gopls check (pull_request) Successful in 2m34s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m36s
Details
Tests and linters / Lint (pull_request) Successful in 3m29s
Details
Tests and linters / Tests (pull_request) Successful in 4m0s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m48s
Details

Browse source 
This allow to not to call `os.Stat` if caller already knows data size.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2024-09-12 12:33:12 +03:00
parent f345fe9a58
commit b33559754d
7 changed files with 92 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pkg/local_object_storage/writecache/storage.go
View file

@ -40,8 +40,8 @@ func (c *cache) openStore(mod mode.ComponentMode) error {
return nil
}
func (c *cache) deleteFromDisk(ctx context.Context, addr oid.Address) {
_, err := c.fsTree.Delete(ctx, common.DeletePrm{Address: addr})
func (c *cache) deleteFromDisk(ctx context.Context, addr oid.Address, size uint64) {
_, err := c.fsTree.Delete(ctx, common.DeletePrm{Address: addr, Size: size})
if err != nil && !client.IsErrObjectNotFound(err) {
c.log.Error(logs.WritecacheCantRemoveObjectFromWritecache, zap.Error(err))
} else if err == nil {