TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 107 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

[#1620] logs: Drop redundant trace_id fields
All checks were successful
DCO action / DCO (pull_request) Successful in 39s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 38s
Details
Vulncheck / Vulncheck (pull_request) Successful in 52s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m4s
Details
Build / Build Components (pull_request) Successful in 2m21s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m23s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m8s
Details
Tests and linters / Lint (pull_request) Successful in 5m47s
Details
Tests and linters / Tests (pull_request) Successful in 6m31s
Details
Tests and linters / gopls check (pull_request) Successful in 2m37s
Details
Tests and linters / Run gofumpt (push) Successful in 32s
Details
Vulncheck / Vulncheck (push) Successful in 58s
Details
Pre-commit hooks / Pre-commit (push) Successful in 1m23s
Details
Build / Build Components (push) Successful in 1m43s
Details
Tests and linters / Staticcheck (push) Successful in 2m24s
Details
Tests and linters / Lint (push) Successful in 3m43s
Details
OCI image / Build container images (push) Successful in 4m34s
Details
Tests and linters / Tests (push) Successful in 4m37s
Details
Tests and linters / Tests with -race (push) Successful in 5m21s
Details
Tests and linters / gopls check (push) Successful in 5m29s
Details

Browse source 
`trace_id` is taken from context.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2025-01-29 16:09:53 +03:00
parent abfd9657f9
commit e1a984e9d8
Signed by: dstepanov-yadro
GPG key ID: 237AF1A763293BC0
24 changed files with 56 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pkg/services/tree/replicator.go
View file

@ -10,7 +10,6 @@ import (
"git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/pilorama"
tracingPkg "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/tracing"
"git.frostfs.info/TrueCloudLab/frostfs-observability/tracing"
cidSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container/id"
netmapSDK "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/netmap"
@ -117,14 +116,12 @@ func (s *Service) ReplicateTreeOp(ctx context.Context, n netmapSDK.NodeInfo, req
if lastErr != nil {
if errors.Is(lastErr, errRecentlyFailed) {
s.log.Debug(ctx, logs.TreeDoNotSendUpdateToTheNode,
zap.String("last_error", lastErr.Error()),
zap.String("trace_id", tracingPkg.GetTraceID(ctx)))
zap.String("last_error", lastErr.Error()))
} else {
s.log.Warn(ctx, logs.TreeFailedToSentUpdateToTheNode,
zap.String("last_error", lastErr.Error()),
zap.String("address", lastAddr),
zap.String("key", hex.EncodeToString(n.PublicKey())),
zap.String("trace_id", tracingPkg.GetTraceID(ctx)))
zap.String("key", hex.EncodeToString(n.PublicKey())))
}
s.metrics.AddReplicateTaskDuration(time.Since(start), false)
return lastErr