TrueCloudLab/frostfs-node

Fix drop non-static buckets during metabase reync #1048

New issue

Closed

opened 2024-03-18 09:48:03 +00:00 by dstepanov-yadro · 2 comments

dstepanov-yadro commented

2024-03-18 09:48:03 +00:00

Member

During metabase resync frostfs-node drops non-static (containerID depended) buckets.
See here:

err = tx.ForEach(func(name []byte, _ *bbolt.Bucket) error {

Expected Behavior

Buckets must be deleted outside of Foreach func.

Current Behavior

Buckets deleted inside of Foreach func. This leads to undefined behavior.

During metabase resync frostfs-node drops non-static (containerID depended) buckets. See here: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/bd216b79cb30e560165095172c44b7e48e2ce362/pkg/local_object_storage/metabase/control.go#L170 ## Expected Behavior Buckets must be deleted outside of `Foreach` func. ## Current Behavior Buckets deleted inside of `Foreach` func. This leads to undefined behavior.

dstepanov-yadro added the

good first issue

labels 2024-03-18 09:48:03 +00:00

dstepanov-yadro self-assigned this 2024-03-19 07:10:32 +00:00

dstepanov-yadro referenced this issue

2024-03-19 08:54:36 +00:00

metabase: Fix drop buckets during resync #1050

fyrchik referenced this issue from a commit

2024-03-19 11:45:09 +00:00

[#1048] metabase: Fix drop buckets during resync

dstepanov-yadro commented

2024-03-20 11:45:52 +00:00

Author

Member

Done

Done

dstepanov-yadro closed this issue

2024-03-20 11:45:52 +00:00

fyrchik reopened this issue

2024-03-25 11:44:44 +00:00

dstepanov-yadro commented

2024-03-26 13:03:38 +00:00

Author

Member

Checked again, fixed

Checked again, fixed

dstepanov-yadro closed this issue

2024-03-26 13:03:40 +00:00

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1048

No description provided.