metabase: Fix drop buckets during resync #1050

dstepanov-yadro · 2024-03-19T08:54:36Z

dstepanov-yadro commented

2024-03-19 08:54:36 +00:00

Relates #1048

BBolt's ForEach functions don't allow to edit iterator items. This leads to undefined behavior.
TestResetDropsContainerBuckets fails without fix.

Relates #1048 BBolt's `ForEach` functions don't allow to edit iterator items. This leads to undefined behavior. `TestResetDropsContainerBuckets` fails without fix.

dstepanov-yadro reviewed 2024-03-19 08:56:00 +00:00

pkg/local_object_storage/metabase/reset_test.go Outdated

					
				@ -0,0 +1,57 @@

				package meta

dstepanov-yadro commented

2024-03-19 08:55:59 +00:00

Moved to separate file to use the meta package to have access to boltdb field.

Moved to separate file to use the `meta` package to have access to `boltdb` field.

dstepanov-yadro requested review from storage-core-committers 2024-03-19 09:12:26 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-03-19 09:12:27 +00:00

aarifullin approved these changes 2024-03-19 09:34:00 +00:00

fyrchik reviewed 2024-03-19 10:43:06 +00:00

pkg/local_object_storage/metabase/control.go Outdated

					
				@ -171,2 +175,3 @@

						for name != nil {

							if _, ok := mStaticBuckets[string(name)]; !ok {

								return tx.DeleteBucket(name)

								nameCopy := bytes.Clone(name)