Improve shard/engine construction in tests #116

New issue

Closed

opened 2023-03-08 23:34:44 +00:00 by snegurochka · 1 comment

snegurochka commented

2023-03-08 23:34:44 +00:00

Member

Original issue: https://github.com/nspcc-dev/neofs-node/issues/1776

We have a lot of different tests which test different things:

Some tests may need 1 shard, others need many.
Some tests need particular error threshold, others use default.
Some tests need to corrupt data on disk and thus may need a custom storage backend constructed beforehand.

The proposal is to have a single newEngine(prm) in tests, where all defaults can be overridden.
This way we can avoid having to create engine/shard manually when writing specific tests.

I have assigned P1 priority, because albeit it is a test refactor, we will certainly need this in Q4, when we will test all failover/storage corruption scenarios.

Original issue: https://github.com/nspcc-dev/neofs-node/issues/1776 We have a lot of different tests which test different things: 1. Some tests may need 1 shard, others need many. 2. Some tests need particular error threshold, others use default. 3. Some tests need to corrupt data on disk and thus may need a custom storage backend constructed beforehand. The proposal is to have a single `newEngine(prm)` in tests, where all defaults can be overridden. This way we can avoid having to create engine/shard manually when writing specific tests. I have assigned P1 priority, because albeit it is a test refactor, we will certainly need this in Q4, when we will test all failover/storage corruption scenarios.