[#116] node: Fix bug with extra generated files in TestReload #220

aarifullin · 2023-04-05T15:50:31Z

aarifullin commented

2023-04-05 15:50:31 +00:00

Create testNewEngine in engineWithShards without default opts

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Create testNewEngine in engineWithShards without default opts Signed-off-by: Airat Arifullin a.arifullin@yadro.com

aarifullin added 1 commit 2023-04-05 15:50:32 +00:00

[#116 ] node: Fix bug with extra generated files in TestReload

ci/woodpecker/pr/pre-commit Pipeline was successful

Details

ci/woodpecker/push/pre-commit Pipeline was successful

Details

ab891517de

* Create testNewEngine in engineWithShards without default opts

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

aarifullin requested review from storage-core-committers 2023-04-05 15:50:39 +00:00

aarifullin requested review from storage-core-developers 2023-04-05 15:50:44 +00:00

aarifullin reviewed 2023-04-05 15:53:26 +00:00

pkg/local_object_storage/engine/control_test.go

					
				@ -321,8 +322,9 @@ func engineWithShards(t *testing.T, path string, num int) (*StorageEngine, []str

					currShards := make([]string, 0, num)

					te := testNewEngine(t).

						setShardsNumAdditionalOpts(t, num, func(id int) []shard.Option {

aarifullin commented

2023-04-05 15:53:26 +00:00

@dstepanov-yadro noticed that tests generate extra *.pilorama files. It turned out that default shards have set Pilorama option that led to generating extra *.pilorama files in TestReload

@dstepanov-yadro noticed that tests generate extra `*.pilorama` files. It turned out that default shards have set `Pilorama` option that led to generating extra `*.pilorama` files in `TestReload`