WIP: tree: Make tree service use specific verbs for APE #1191

aarifullin · 2024-06-19T14:42:47Z

aarifullin commented

2024-06-19 14:42:47 +00:00

Update go.mod;
Factor out eACL tables as they are no longer applied for access checks;
Fix unit-tests.

* Update go.mod; * Factor out eACL tables as they are no longer applied for access checks; * Fix unit-tests.

aarifullin added 1 commit 2024-06-19 14:42:54 +00:00

Tests and linters / Lint (pull_request) Failing after 23s Details

Vulncheck / Vulncheck (pull_request) Successful in 2m0s Details

Build / Build Components (1.22) (pull_request) Successful in 7m13s Details

DCO action / DCO (pull_request) Failing after 7m57s Details

Build / Build Components (1.21) (pull_request) Successful in 8m59s Details

Tests and linters / gopls check (pull_request) Successful in 11m30s Details

Tests and linters / Staticcheck (pull_request) Successful in 11m51s Details

Tests and linters / Tests (1.21) (pull_request) Failing after 13m8s Details

Tests and linters / Tests (1.22) (pull_request) Successful in 15m27s Details

Tests and linters / Tests with -race (pull_request) Successful in 15m46s Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 18m3s Details

7a62e82b0d [#XX] tree: Make tree service use specific verbs for APE

* Update go.mod;
* Factor out eACL tables as they are no longer applied for access checks;
* Fix unit-tests.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

aarifullin force-pushed feat/treesvc_verbs from 7a62e82b0d to 7f88e81dd4

2024-06-19 14:43:29 +00:00

Compare

aarifullin requested review from storage-core-committers 2024-06-19 15:11:12 +00:00

aarifullin requested review from storage-core-developers 2024-06-19 15:11:14 +00:00

aarifullin commented

2024-06-19 15:13:56 +00:00

Poster

Depends on TrueCloudLab/policy-engine#81

Depends on https://git.frostfs.info/TrueCloudLab/policy-engine/pulls/81

acid-ant reviewed 2024-06-20 07:36:00 +00:00

pkg/services/tree/signature_test.go

													
				@ -170,3 +240,3 @@

						t.Run("invalid bearer CID", func(t *testing.T) {

							bt := testBearerToken(cid2, privs[1].PublicKey(), privs[2].PublicKey())

							bt := testBearerToken(cid2, privs[1].PublicKey(), privs[2].PublicKey()) //testBearerToken(cid2, privs[1].PublicKey(), privs[2].PublicKey())

acid-ant commented

2024-06-20 07:32:51 +00:00

Comment needs to be removed?

pkg/services/tree/signature_test.go

													
				@ -179,2 +249,3 @@

						t.Run("invalid bearer owner", func(t *testing.T) {

							bt := testBearerToken(cid1, privs[1].PublicKey(), privs[2].PublicKey())

							bt := testBearerToken(cid1, privs[1].PublicKey(), privs[2].PublicKey()) //testBearerToken(cid1, privs[1].PublicKey(), privs[2].PublicKey())