TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

WIP: tree: Make tree service use specific verbs for APE #1191

Closed
aarifullin wants to merge 1 commit from aarifullin/frostfs-node:feat/treesvc_verbs into master
pull from: aarifullin/frostfs-node:feat/treesvc_verbs
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files changed 6 +282 -288
aarifullin commented 2024-06-19 14:42:47 +00:00
Member
Copy link
  • Update go.mod;
  • Factor out eACL tables as they are no longer applied for access checks;
  • Fix unit-tests.
* Update go.mod; * Factor out eACL tables as they are no longer applied for access checks; * Fix unit-tests.
aarifullin force-pushed feat/treesvc_verbs from 7a62e82b0d to 7f88e81dd4 2024-06-19 14:43:29 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-06-19 15:11:12 +00:00
aarifullin requested review from storage-core-developers 2024-06-19 15:11:14 +00:00
aarifullin commented 2024-06-19 15:13:56 +00:00
Author
Member
Copy link

Depends on TrueCloudLab/policy-engine#81

Depends on https://git.frostfs.info/TrueCloudLab/policy-engine/pulls/81
acid-ant reviewed 2024-06-20 07:36:00 +00:00
pkg/services/tree/signature_test.go
@ -170,3 +240,3 @@
t.Run("invalid bearer CID", func(t *testing.T) {
bt := testBearerToken(cid2, privs[1].PublicKey(), privs[2].PublicKey())
bt := testBearerToken(cid2, privs[1].PublicKey(), privs[2].PublicKey()) //testBearerToken(cid2, privs[1].PublicKey(), privs[2].PublicKey())
acid-ant commented 2024-06-20 07:32:51 +00:00
Member
Copy link

Comment needs to be removed?

Comment needs to be removed?
pkg/services/tree/signature_test.go
@ -179,2 +249,3 @@
t.Run("invalid bearer owner", func(t *testing.T) {
bt := testBearerToken(cid1, privs[1].PublicKey(), privs[2].PublicKey())
bt := testBearerToken(cid1, privs[1].PublicKey(), privs[2].PublicKey()) //testBearerToken(cid1, privs[1].PublicKey(), privs[2].PublicKey())
acid-ant commented 2024-06-20 07:33:41 +00:00
Member
Copy link

Comment needs to be removed?

Comment needs to be removed?
fyrchik changed title from tree: Make tree service use specific verbs for APE to WIP: tree: Make tree service use specific verbs for APE 2024-06-20 11:28:45 +00:00
fyrchik closed this pull request 2024-07-22 12:01:58 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 7m58s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 7m41s
Required
Details
Build / Build Components (1.22) (pull_request) Successful in 10m26s
Required
Details
Build / Build Components (1.21) (pull_request) Successful in 10m37s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 10m58s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 11m5s
Required
Details
Tests and linters / Lint (pull_request) Successful in 12m15s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 17m0s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 17m36s
Required
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 17m31s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 18m39s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1191
No description provided.
Delete branch "aarifullin/frostfs-node:feat/treesvc_verbs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?